From: Sven Verdoolaege <skimo@kotnet.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t9500: skip gitweb tests if perl version is too old
Date: Sat, 23 Jun 2007 12:51:19 +0200 [thread overview]
Message-ID: <20070623105118.GY955MdfPADPa@greensroom.kotnet.org> (raw)
In-Reply-To: <7vps3n3rm7.fsf@assigned-by-dhcp.pobox.com>
On Sat, Jun 23, 2007 at 03:14:08AM -0700, Junio C Hamano wrote:
> Well, "Encode::FB_CLUCK" is a bogus symbol even in recent Perl.
> IOW, the tested function does not seem to care if I give
> whatever garbage as the second parameter.
>
> But I guess you are only interested if the perl used to run
> gitweb barfs with that two parameter, so the original check
> would be the right way.
Indeed. gitweb doesn't use FB_CLUCK and if it did, we would
want to know about it (and not skip the tests).
skimo
prev parent reply other threads:[~2007-06-23 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 15:49 [PATCH] t9500: skip gitweb tests if perl version is too old Sven Verdoolaege
2007-06-23 6:31 ` Junio C Hamano
2007-06-23 8:57 ` Sven Verdoolaege
2007-06-23 10:14 ` Junio C Hamano
2007-06-23 10:51 ` Sven Verdoolaege [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070623105118.GY955MdfPADPa@greensroom.kotnet.org \
--to=skimo@kotnet.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=skimo@liacs.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).