From: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH]: tree-walk.h: Warning fix
Date: Sat, 23 Jun 2007 23:10:21 -0300 [thread overview]
Message-ID: <20070623231021.40a6f3be@gnut> (raw)
In-Reply-To: <7v1wg39oqc.fsf@assigned-by-dhcp.pobox.com>
Em Fri, 22 Jun 2007 23:19:55 -0700
Junio C Hamano <gitster@pobox.com> escreveu:
| "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
| writes:
|
| > diff --git a/tree-walk.h b/tree-walk.h
| > index ee747ab..625198f 100644
| > --- a/tree-walk.h
| > +++ b/tree-walk.h
| > @@ -22,7 +22,7 @@ static inline const unsigned char *tree_entry_extract(struct tree_desc *desc, co
| >
| > static inline int tree_entry_len(const char *name, const unsigned char *sha1)
| > {
| > - return (char *)sha1 - (char *)name - 1;
| > + return (const char *)sha1 - (const char *)name - 1;
| > }
| >
| > void update_tree_entry(struct tree_desc *);
|
| Grumble. Incoming "name" is already (const char*), isn't it?
| I'd cast only the sha1 side and apply.
Yes, you're right. I'll fix it and apply again.
Thanks a lot for the feedback.
prev parent reply other threads:[~2007-06-24 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 2:11 [PATCH]: tree-walk.h: Warning fix Luiz Fernando N. Capitulino
2007-06-23 6:19 ` Junio C Hamano
2007-06-24 2:10 ` Luiz Fernando N. Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070623231021.40a6f3be@gnut \
--to=lcapitulino@mandriva.com.br \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).