Re: fastimport pull request

Re: fastimport pull request

[Junio C Hamano]

"Shawn O. Pearce" <spearce@spearce.org> writes:

> The following changes since commit 45fd8bd32dd68ce6b14a406d0abbd6f56490131c:
>   Ismail Dönmez (1):
>         Change default man page path to /usr/share/man
>
> are available in the git repository at:
>
>   repo.or.cz:/srv/git/git/fastimport.git master
>
> and are intended for your master branch, aka the 1.5.3 series.
>
> Shawn O. Pearce (2):
>       Avoid src:dst syntax as default bash completion for git push
>       Import branch 'git-p4' of git://repo.or.cz/fast-export
>
> Yes, that's right, I pulled in Simon's git-p4 work.  :-)
>
> Benjamin Sergeant (1):  ...
> Han-Wen Nienhuys (30):  ...
> Kevin Green (1):        ...
> Marius Storm-Olsen (7): ...
> Simon Hausmann (222):   ...

I had an impression from reading #git log and mailing list
traffic, that you guys were afraid that the development history,
and especially the commit log messages on this branch, were, eh,
less than optimal.  So I got curious and took a look --- it does
not look too bad.  It is a nontrivial amount of code (1.5k lines
of Python) and is understandable to have meaningful history
behind it.

Pulled, and pushed out.

Re: fastimport pull request

[Shawn O. Pearce]

Junio C Hamano <gitster@pobox.com> wrote:
> I had an impression from reading #git log and mailing list
> traffic, that you guys were afraid that the development history,
> and especially the commit log messages on this branch, were, eh,
> less than optimal.  So I got curious and took a look --- it does
> not look too bad.  It is a nontrivial amount of code (1.5k lines
> of Python) and is understandable to have meaningful history
> behind it.

That was true of the first version of the branch offered up by Simon.

After my initial reply Simon cleaned up the history and made many
of the messages more meaningful, and added SBO lines to them.
So the history you saw when you pulled was much improved over the
original version we were discussing on the list.

-- 
Shawn.