From: bdowning@lavos.net (Brian Downing)
To: mdl123@verizon.net
Cc: gitster@pobox.com, paulus@samba.org, git@vger.kernel.org
Subject: Re: [PATCH] gitk - Make selection highlight color configurable
Date: Tue, 26 Jun 2007 12:54:52 -0500 [thread overview]
Message-ID: <20070626175452.GS4087@lavos.net> (raw)
In-Reply-To: <1182825801300-git-send-email-mdl123@verizon.net>
Mark Levedahl wrote:
> Cygwin's tk by default uses a very dark selection background color
> that makes the currently selected text almost unreadable. On linux,
> the default selection background is a light gray which is very usable.
> This makes the default a light gray everywhere but allows the user to
> configure the color as well.
I noticed this, and also noticed that the dark color in question was
in fact the default Windows selection background color. Unfortunately,
wish/gitk doesn't also use the default Windows selection foreground color
(white), so the result is pretty unreadable.
When playing with Git on Windows I worked around the problem by changing
the selection color system-wide.
(This patch is perhaps better than making it work the "Windows way"
with the right system foreground color, though, as the tag and branch
markers are also pretty ugly against a dark background...)
-bcd
--
*** Brian Downing <bdowning@lavos.net>
next prev parent reply other threads:[~2007-06-26 17:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 16:05 Mark Levedahl's gitk patches Johannes Sixt
2007-06-26 2:41 ` Mark Levedahl
2007-06-26 2:43 ` [PATCH] gitk - Make selection highlight color configurable Mark Levedahl
2007-06-26 2:43 ` [PATCH] gitk - Update fontsize in patch / tree list Mark Levedahl
2007-06-26 2:43 ` [PATCH] gitk - Allow specifying tabstop as other than default 8 characters Mark Levedahl
2007-06-26 17:54 ` Brian Downing [this message]
2007-06-26 4:02 ` Mark Levedahl's gitk patches Paul Mackerras
2007-06-27 0:41 ` Junio C Hamano
2007-06-28 0:15 ` Paul Mackerras
2007-06-27 1:51 ` [PATCH] gitk - bugfix - Update selection background colorbar in prefs dialog Mark Levedahl
2007-06-27 1:51 ` [PATCH] gitk - Use a spinbox for setting tabstop settings Mark Levedahl
-- strict thread matches above, loose matches on Subject: below --
2007-05-20 15:45 [PATCH] gitk - Allow specifying tabstop as other than default 8 characters Mark Levedahl
2007-05-20 16:12 ` [PATCH] gitk - Make selection highlight color configurable Mark Levedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070626175452.GS4087@lavos.net \
--to=bdowning@lavos.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mdl123@verizon.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).