From: Sven Verdoolaege <skimo@liacs.nl>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: Louis-Noel Pouchet <louis-noel.pouchet@inria.fr>
Subject: [PATCH] git-clone: fetch possibly detached HEAD over dumb http
Date: Thu, 28 Jun 2007 12:52:08 +0200 [thread overview]
Message-ID: <20070628105208.GA11105@liacs.nl> (raw)
git-clone supports cloning from a repo with detached HEAD,
but if this HEAD is not behind any branch tip then it
would not have been fetched over dumb http, resulting in a
fatal: Not a valid object name HEAD
Since 928c210a, this would also happen on a http repo
with a HEAD that is a symbolic link where someone has
forgotton to run update-server-info.
Signed-off-by: Sven Verdoolaege <skimo@liacs.nl>
---
git-clone.sh | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-clone.sh b/git-clone.sh
index bd44ce1..cdbbc20 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -70,7 +70,8 @@ Perhaps git-update-server-info needs to be run there?"
git-http-fetch $v -a -w "$tname" "$sha1" "$1" || exit 1
done <"$clone_tmp/refs"
rm -fr "$clone_tmp"
- http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" ||
+ http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" &&
+ git-http-fetch $v -a $(cat "$GIT_DIR/REMOTE_HEAD") "$1" ||
rm -f "$GIT_DIR/REMOTE_HEAD"
}
--
1.5.2.2.585.g9cc0-dirty
next reply other threads:[~2007-06-28 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-28 10:52 Sven Verdoolaege [this message]
2007-06-29 0:02 ` [PATCH] git-clone: fetch possibly detached HEAD over dumb http Junio C Hamano
2007-06-29 8:11 ` Sven Verdoolaege
2007-06-29 8:31 ` Sven Verdoolaege
2007-06-30 13:33 ` Alex Riesen
2007-06-30 13:45 ` Sven Verdoolaege
2007-06-30 22:23 ` Alex Riesen
2007-07-01 2:22 ` Junio C Hamano
2007-07-01 16:40 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070628105208.GA11105@liacs.nl \
--to=skimo@liacs.nl \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=louis-noel.pouchet@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).