From: Frank Lichtenheld <frank@lichtenheld.de>
To: Theodore Tso <tytso@mit.edu>
Cc: Jeff King <peff@peff.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jim Meyering <jim@meyering.net>,
git@vger.kernel.org
Subject: Re: [PATCH] Don't fflush(stdout) when it's not helpful
Date: Fri, 29 Jun 2007 03:05:08 +0200 [thread overview]
Message-ID: <20070629010507.GL12721@planck.djpig.de> (raw)
In-Reply-To: <20070628235319.GD29279@thunk.org>
On Thu, Jun 28, 2007 at 07:53:19PM -0400, Theodore Tso wrote:
> Good point. Here's a revised patch where GIT_FLUSH=0 and GIT_FLASH=1
> trumps any hueristics.
[...]
> + else if (getenv("GIT_NEVER_FLUSH_STDOUT") ||
> + ((fstat(fileno(stdout), &st) == 0) &&
> + S_ISREG(st.st_mode)))
> + stdout_is_file = 1;
> + else
> + stdout_is_file = 0;
> + }
Any particular reason why you still check for GIT_NEVER_FLUSH_STDOUT in
addition to GIT_FLUSH?
Gruesse,
--
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/
next prev parent reply other threads:[~2007-06-29 1:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 20:32 [PATCH] git-rev-list: give better diagnostic for failed write Jim Meyering
2007-06-25 20:59 ` Linus Torvalds
2007-06-25 21:52 ` Jim Meyering
2007-06-25 22:20 ` Linus Torvalds
2007-06-25 22:56 ` Linus Torvalds
2007-06-25 23:01 ` Linus Torvalds
2007-06-27 8:56 ` Jim Meyering
2007-06-25 23:16 ` Linus Torvalds
2007-06-26 17:11 ` Theodore Tso
2007-06-26 17:32 ` Linus Torvalds
2007-06-26 22:04 ` Theodore Tso
2007-06-26 22:32 ` Linus Torvalds
2007-06-28 19:04 ` Theodore Tso
2007-06-28 21:34 ` Jeff King
2007-06-28 23:53 ` [PATCH] Don't fflush(stdout) when it's not helpful Theodore Tso
2007-06-29 1:05 ` Frank Lichtenheld [this message]
2007-06-29 3:48 ` Theodore Tso
2007-06-29 6:38 ` Jeff King
2007-06-29 7:07 ` Junio C Hamano
2007-06-29 16:06 ` Linus Torvalds
2007-06-29 17:40 ` Theodore Tso
2007-06-29 23:43 ` Linus Torvalds
2007-06-30 2:15 ` Junio C Hamano
2007-06-30 4:24 ` Linus Torvalds
2007-06-30 14:27 ` Theodore Tso
2007-06-30 18:42 ` Junio C Hamano
2007-06-26 9:06 ` [PATCH] git-rev-list: give better diagnostic for failed write Jeff King
2007-06-26 17:12 ` Linus Torvalds
2007-06-27 8:59 ` Jim Meyering
2007-06-27 16:06 ` Linus Torvalds
2007-06-25 21:39 ` Jim Meyering
2007-06-25 21:53 ` Linus Torvalds
2007-06-25 22:08 ` Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070629010507.GL12721@planck.djpig.de \
--to=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
--cc=jim@meyering.net \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).