From: Alex Riesen <raa.lkml@gmail.com>
To: skimo@liacs.nl
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Louis-Noel Pouchet <louis-noel.pouchet@inria.fr>
Subject: Re: [PATCH] git-clone: fetch possibly detached HEAD over dumb http
Date: Sun, 1 Jul 2007 00:23:36 +0200 [thread overview]
Message-ID: <20070630222336.GA2703@steel.home> (raw)
In-Reply-To: <20070630134542.GF7969MdfPADPa@greensroom.kotnet.org>
Sven Verdoolaege, Sat, Jun 30, 2007 15:45:44 +0200:
> On Sat, Jun 30, 2007 at 03:33:10PM +0200, Alex Riesen wrote:
> > Sven Verdoolaege, Fri, Jun 29, 2007 10:31:08 +0200:
> > > + head_sha1=`cat "$GIT_DIR/REMOTE_HEAD"`
> > > + case "$head_sha1" in
> > > + 'ref: refs/'*)
> > > + ;;
> >
> > And what do you do if the HEAD is a reflink on something not in refs/?
> > Like "ref: tmp"? Yes, it is unlikely, but is not forbidden.
>
> It may not be forbidden, but I don't think it would
> work with current git-clone either.
>
Every command which needs a proper .git will not work, so I take this
back completely.
The check for .git validity includes checking if HEAD contains
something sane, and this check is very simple: the HEAD is read
(readlink(2) or plain read(2)) and tested if it contains a
reference starting with "refs/", which maybe inconsistent with
resolve_gitlink_ref, but probably ok.
next prev parent reply other threads:[~2007-06-30 22:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-28 10:52 [PATCH] git-clone: fetch possibly detached HEAD over dumb http Sven Verdoolaege
2007-06-29 0:02 ` Junio C Hamano
2007-06-29 8:11 ` Sven Verdoolaege
2007-06-29 8:31 ` Sven Verdoolaege
2007-06-30 13:33 ` Alex Riesen
2007-06-30 13:45 ` Sven Verdoolaege
2007-06-30 22:23 ` Alex Riesen [this message]
2007-07-01 2:22 ` Junio C Hamano
2007-07-01 16:40 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070630222336.GA2703@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=louis-noel.pouchet@inria.fr \
--cc=skimo@liacs.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).