git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: しらいしななこ <nanako3@bluebottle.com>, GIT <git@vger.kernel.org>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Document git-stash
Date: Mon, 2 Jul 2007 00:08:00 -0400	[thread overview]
Message-ID: <20070702040800.GA17384@coredump.intra.peff.net> (raw)
In-Reply-To: <7vps3b4xcj.fsf@assigned-by-dhcp.cox.net>

On Sun, Jul 01, 2007 at 02:39:56PM -0700, Junio C Hamano wrote:

> For paths that are cleanly merged with this three-way merge,
> merge-recursive updates the working tree and the index.  That
> means if you do "git diff", you would not see the local changes
> that were carried forward would not be visible, and you would
> need "git diff HEAD" to view them.  I found it confusing, and
> that was the suggestion I sent was about.  Nana's "3rd try", which
> I applied and pushed to 'next', addresses this issue by running
> "read-tree --reset $c_tree" (where $c_tree is the contents of
> the index before replaying the stash).
> 
> This is not ideal.  We would want to see "git diff" for such a
> path show difference similar to difference between I and W.

Ah, I get it now. Thanks for the explanation.

I see you gutted the confusing text from the manpage...I think what you
have now is conceptually much simpler, and it won't bite anyone unless
they are trying to do something clever with the index. In which case I
hope they will be able to use the description of how the stash is stored
to poke around.

-Peff

  reply	other threads:[~2007-07-02  4:08 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-30  1:29 [PATCH (2nd try)] Add git-stash script しらいしななこ
2007-06-30  2:05 ` Johannes Schindelin
2007-06-30  5:37   ` [PATCH (3rd " しらいしななこ
2007-06-30  6:12     ` Jeff King
2007-06-30  6:25       ` Junio C Hamano
2007-06-30 15:41     ` Johannes Schindelin
2007-06-30 17:19       ` Junio C Hamano
2007-06-30 23:27       ` しらいしななこ
2007-06-30 15:44     ` [PATCH] Add a manual page for git-stash Johannes Schindelin
2007-06-30 16:38       ` Frank Lichtenheld
2007-06-30 17:48         ` Johannes Schindelin
2007-06-30 18:45           ` Frank Lichtenheld
2007-06-30 17:44       ` Junio C Hamano
2007-06-30 17:56         ` Johannes Schindelin
2007-06-30 18:13           ` Junio C Hamano
2007-06-30 18:44             ` Johannes Schindelin
2007-07-01  5:26           ` [PATCH] Document git-stash しらいしななこ
2007-07-01  6:48             ` Junio C Hamano
2007-07-01  8:07             ` Jeff King
2007-07-01  8:38               ` Junio C Hamano
2007-07-01  9:06               ` しらいしななこ
     [not found]               ` <200707010910.l619A23c027837@mi0.bluebottle.com>
2007-07-01  9:19                 ` Jeff King
2007-07-01 21:39                   ` Junio C Hamano
2007-07-02  4:08                     ` Jeff King [this message]
2007-07-01 21:54               ` Junio C Hamano
2007-07-01 22:57                 ` Johannes Schindelin
2007-07-02  4:10                 ` Jeff King
2007-07-02 10:33                   ` Johannes Schindelin
2007-07-02 10:44                     ` [PATCH] git-stash: Make "save" the default operation again Johannes Schindelin
2007-07-02 11:00                       ` Jeff King
2007-07-02 11:15                         ` Johannes Schindelin
2007-07-02 23:11                           ` Junio C Hamano
2007-07-01  5:20       ` [PATCH] Add a manual page for git-stash Junio C Hamano
2007-06-30 16:06     ` [PATCH] Add tests " Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070702040800.GA17384@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nanako3@bluebottle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).