From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] stash: end commit log with a newline
Date: Tue, 3 Jul 2007 10:32:27 -0400 [thread overview]
Message-ID: <20070703143227.GD18597@coredump.intra.peff.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0707031228460.4071@racer.site>
On Tue, Jul 03, 2007 at 12:29:42PM +0100, Johannes Schindelin wrote:
> Why not
>
> w_commit=$(echo "WIP on $msg" |
>
> Hmm? It is shorter and more to the point. IMHO it is also more common.
Because echo cannot reliably reproduce arbitrary strings. See commits:
a23bfaed..4b7cc26a
You can add this to your list of reasons to rewrite everything in C.
-Peff
next prev parent reply other threads:[~2007-07-03 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 8:59 [PATCH] stash: end commit log with a newline Uwe Kleine-König
2007-07-03 11:29 ` Johannes Schindelin
2007-07-03 14:01 ` Uwe Kleine-König
2007-07-03 14:32 ` Jeff King [this message]
2007-07-04 5:10 ` しらいしななこ
2007-07-04 5:10 ` Junio C Hamano
2007-07-04 7:44 ` Uwe Kleine-König
2007-07-04 23:18 ` しらいしななこ
[not found] <200707042324.l64NOp8I019289@mi0.bluebottle.com>
2007-07-05 5:46 ` Junio C Hamano
2007-07-05 11:58 ` Uwe Kleine-König
2007-07-05 16:47 ` Junio C Hamano
2007-07-05 23:54 ` しらいしななこ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070703143227.GD18597@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=ukleinek@informatik.uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).