From: Peter Baumann <waste.manager@gmx.de>
To: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] repack: don't report "Nothing new to pack." if -q is given
Date: Tue, 3 Jul 2007 20:19:23 +0200 [thread overview]
Message-ID: <20070703181923.GE4580@xp.machine.xx> (raw)
In-Reply-To: <20070703084757.GA4694@lala>
On Tue, Jul 03, 2007 at 10:47:58AM +0200, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
> ---
> This patch is on top of maint. For master and next you need
> s/name/names/.
>
> Best regards
> Uwe
>
> git-repack.sh | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/git-repack.sh b/git-repack.sh
> index ddfa8b4..d980275 100755
> --- a/git-repack.sh
> +++ b/git-repack.sh
> @@ -65,7 +65,9 @@ args="$args $local $quiet $no_reuse_delta$extra"
> name=$(git-pack-objects --non-empty --all --reflog $args </dev/null "$PACKTMP") ||
> exit 1
> if [ -z "$name" ]; then
> - echo Nothing new to pack.
> + if test -q "$quiet"; then
> + echo Nothing new to pack.
> + fi
This looks wrong, especially as I can't find a '-q' in the manpage of "test".
Perhaps you ment something like the following code, which is already used in
the script:
if test "$quiet" != '-q'; then
echo ...
fi
-Peter
next prev parent reply other threads:[~2007-07-03 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 8:47 [PATCH] repack: don't report "Nothing new to pack." if -q is given Uwe Kleine-König
2007-07-03 18:19 ` Peter Baumann [this message]
2007-07-03 19:17 ` Uwe Kleine-König
2007-07-04 5:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070703181923.GE4580@xp.machine.xx \
--to=waste.manager@gmx.de \
--cc=git@vger.kernel.org \
--cc=ukleinek@informatik.uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).