git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	git@vger.kernel.org
Subject: Re: [PATCH] gitk: fix for "gitk <ambiguous-name> --"
Date: Wed, 4 Jul 2007 10:38:49 +0200	[thread overview]
Message-ID: <20070704083849.GA6970@informatik.uni-freiburg.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0707032353330.4071@racer.site>

Hello Johannes,

> If you have an ambiguous ref, i.e. a file in the working directory bears
> the same name, you have to use "--" at the end to disambiguate ref from
> file. This works with "git rev-list". Make it work with gitk, too.

This fixes only one half of the problem.  Now 

	gitk fixes ^linus/master --

works fine, but 

	gitk fixes ^linus/master

still hangs.  

I didn't try Gerrits patch yet.

BTW, I don't use a range, because originally I used something like:

	git branch | cut -b3- | grep -v ^attic/ | xargs gitk ^linus/master

Now I have to think how I can add the ending "--" ...

Best regards
Uwe

-- 
Uwe Kleine-König

5 out of 4 people have trouble with fractions.

  parent reply	other threads:[~2007-07-04  8:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-03 20:23 [BUG] gitk fails with argument that is both existing directory and branch name Uwe Kleine-König
2007-07-03 21:55 ` Johannes Schindelin
2007-07-03 22:17   ` Linus Torvalds
2007-07-03 22:44     ` Johannes Schindelin
2007-07-03 22:55     ` [PATCH] gitk: fix for "gitk <ambiguous-name> --" Johannes Schindelin
2007-07-04  7:37       ` Gerrit Pape
2007-07-04  8:38       ` Uwe Kleine-König [this message]
2007-07-04 10:44       ` Paul Mackerras
2007-07-04 16:58         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070704083849.GA6970@informatik.uni-freiburg.de \
    --to=ukleinek@informatik.uni-freiburg.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).