From: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: torvalds@linux-foundation.org, gitster@pobox.com,
mkraai@beckman.com, madcoder@debian.org, git@vger.kernel.org
Subject: Re: [PATCH] Prefer $EMAIL over auto-generated user@hostname.
Date: Fri, 6 Jul 2007 17:11:45 +0200 [thread overview]
Message-ID: <20070706151145.GA15341@informatik.uni-freiburg.de> (raw)
In-Reply-To: <468E59B3.7080007@nrlssc.navy.mil>
Hello Brandon,
Brandon Casey wrote:
> struct passwd *pw = NULL;
> + char *email;
Indention error. Otherwise it looks good (just from reading the patch).
Best regards
Uwe
--
Uwe Kleine-König
Set the I_WANT_A_BROKEN_PS environment variable to force BSD syntax ...
-- manpage of procps
next prev parent reply other threads:[~2007-07-06 15:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 15:03 [PATCH] Prefer $EMAIL over auto-generated user@hostname Brandon Casey
2007-07-06 15:11 ` Uwe Kleine-König [this message]
2007-07-06 15:22 ` Brandon Casey
2007-07-06 15:32 ` Johannes Schindelin
2007-07-06 15:51 ` Brandon Casey
2007-07-06 15:59 ` Alex Riesen
2007-07-06 15:59 ` Vincent Hanquez
2007-07-06 16:22 ` Alex Riesen
2007-07-06 16:23 ` Alex Riesen
-- strict thread matches above, loose matches on Subject: below --
2007-07-06 16:14 Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070706151145.GA15341@informatik.uni-freiburg.de \
--to=ukleinek@informatik.uni-freiburg.de \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
--cc=mkraai@beckman.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).