git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 3/4] --decorate now decorates ancestors, too
Date: Tue, 10 Jul 2007 22:27:14 -0400	[thread overview]
Message-ID: <20070711022714.GI27033@thunk.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0707110229320.4047@racer.site>

On Wed, Jul 11, 2007 at 02:29:49AM +0100, Johannes Schindelin wrote:
> 
> The option --decorate changed default behavior: Earlier, it decorated
> commits pointed to by any ref.  The new behavior is this: decorate the
> with the given refs and its ancestors, i.e.
> 
> 	git log --decorate next master
> 
> will show "next", "next^", "next~2", ..., "master", "master^", ...
> in parenthesis after the commit name.

I'm wondering how useful the default is.  The arguments get used for
two things; both for git-log to decide what revisions to display, and
which refs to decorate, right?  I'm not sure that overloading is such
a great idea.

Also, I note that "git log --decorate" does nothing at all.  Maybe it
would be better to keep the default to be "any-ref" instead of "given"?

		      	 	   	    - Ted

  reply	other threads:[~2007-07-11  2:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-11  1:28 [PATCH 0/4] Make --decorate more useful Johannes Schindelin
2007-07-11  1:28 ` [PATCH 1/4] Move add_name_decoration() and add_ref_decoration() to commit.[ch] Johannes Schindelin
2007-07-11  1:29 ` [PATCH 2/4] Move the --decorate option from builtin-log.c to revision.c Johannes Schindelin
2007-07-12 18:45   ` Junio C Hamano
2007-07-13 15:38     ` Johannes Schindelin
2007-07-11  1:29 ` [PATCH 3/4] --decorate now decorates ancestors, too Johannes Schindelin
2007-07-11  2:27   ` Theodore Tso [this message]
2007-07-12 18:45     ` Junio C Hamano
2007-07-14  0:23       ` Johannes Schindelin
2007-07-21 22:26       ` Johannes Schindelin
2007-07-11  1:30 ` [PATCH 4/4] --decorate: prefer shorter names Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070711022714.GI27033@thunk.org \
    --to=tytso@mit.edu \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).