git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Hausmann <simon@lst.de>
To: "Alex Riesen" <raa.lkml@gmail.com>
Cc: "Marius Storm-Olsen" <marius@trolltech.com>,
	git@vger.kernel.org, "Junio C Hamano" <junkio@cox.net>
Subject: Re: [PATCH] Fix git-p4 on Windows to not use the Posix sysconf
Date: Fri, 13 Jul 2007 15:33:54 +0200	[thread overview]
Message-ID: <200707131533.55544.simon@lst.de> (raw)
In-Reply-To: <81b0412b0707130603q69857564i1ba418b74397a33d@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

On Friday 13 July 2007 15:03:51 Alex Riesen wrote:
> On 7/13/07, Marius Storm-Olsen <marius@trolltech.com> wrote:
> >      argmax = min(4000, os.sysconf('SC_ARG_MAX'))
>
> I wonder why the code in question does not use "-x"?
> I use it git-p4-import and haven't seen the limit yet.
> I.e.:
>
>    $ ls |p4 -x - print -q
>    $ p4 help usage
>    ...
>    The -x flag instructs p4 to read arguments, one per line, from the
>    named file.  If the file is named '-', then standard input is read.
>    ...

Good idea!


I still think the patch makes sense as stop-gap for 1.5.3 though, because 
without it git-p4 doesn't work at all on Windows.

Simon

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-07-13 13:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-13 12:56 [PATCH] Fix git-p4 on Windows to not use the Posix sysconf Marius Storm-Olsen
2007-07-13 13:03 ` Alex Riesen
2007-07-13 13:33   ` Simon Hausmann [this message]
2007-07-15  2:49     ` Shawn O. Pearce
2007-07-15  6:12       ` Junio C Hamano
2007-07-16  5:35         ` Shawn O. Pearce
2007-07-16  7:00           ` Junio C Hamano
2007-07-16 18:30           ` Simon Hausmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707131533.55544.simon@lst.de \
    --to=simon@lst.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=marius@trolltech.com \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).