From: Alex Riesen <raa.lkml@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] fall back to mozilla's sha.h if openssl/sha.h is not available
Date: Sat, 14 Jul 2007 17:12:31 +0200 [thread overview]
Message-ID: <20070714151231.GD2544@steel.home> (raw)
In-Reply-To: <20070714145013.GA14488@piper.oerlikon.madduck.net>
martin f krafft, Sat, Jul 14, 2007 16:50:13 +0200:
> also sprach Alex Riesen <raa.lkml@gmail.com> [2007.07.14.1623 +0200]:
> > > This should possibly go to configure.ac, but maybe *also* to Makefile to make
> >
> > Definitely. It should it least skip the test if NO_OPENSSL is already
> > defined.
>
> Reading this as a yes, here is the patch adding this. ...
I was not clear. Read it as NO.
> My autotools knowledge is limited, but I might then look at adding
> the fall back to configure.ac too.
Some (me, for one) will consider it the only place where it should be
> Btw: I've done a lot of things wrong on this mailing list already,
> for which I'd like to apologise. Thanks to those who told me
> privately off my faux pas. I hope those won't be necessary anymore.
If I were you, I would have considered CPPFLAGS and CFLAGS and added a
check if HAS_OPENSSL already set.
And BTW doesn't it strike you as a little bit odd that noone has done
that in Makefile before you? Could that be because configure is
considered the _right_ place for this kind of stuff?
next prev parent reply other threads:[~2007-07-14 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 9:24 [PATCH] fall back to mozilla's sha.h if openssl/sha.h is not available martin f. krafft
2007-07-14 14:23 ` Alex Riesen
2007-07-14 14:50 ` martin f krafft
2007-07-14 15:12 ` Alex Riesen [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-14 9:25 martin f. krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070714151231.GD2544@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).