From: Sean <seanlkml@sympatico.ca>
To: "Marco Costalba" <mcostalba@gmail.com>
Cc: "Alex Riesen" <raa.lkml@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Add --show-size to git log to print message size
Date: Sun, 15 Jul 2007 12:34:22 -0400 [thread overview]
Message-ID: <20070715123422.9a431506.seanlkml@sympatico.ca> (raw)
In-Reply-To: <e5bfff550707150927l745926f0nab04ad82dff913@mail.gmail.com>
On Sun, 15 Jul 2007 18:27:41 +0200
"Marco Costalba" <mcostalba@gmail.com> wrote:
> But your scheme does not fail if the patch is not \n terminated ?
I'm pretty sure there is always a preceding end-of-line marker,
before the terminating NUL; although i haven't broken down and
read the code yet.
> It can happen if the patch adds lines at the end of a file and the
> last line is not \n terminated.
>
> In this case your scheme seems to miss the good next revision boundary.
>
Just tested this case here with "git log --parents --pretty=raw -z -r -p"
and git prints out: "\ No newline at end of file" followed by a newline
and then the NUL.
Sean
next prev parent reply other threads:[~2007-07-15 16:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 16:52 [PATCH] Add --show-size to git log to print message size Marco Costalba
2007-07-14 19:03 ` Junio C Hamano
2007-07-14 20:46 ` Marco Costalba
2007-07-15 9:35 ` Alex Riesen
2007-07-15 10:06 ` Marco Costalba
2007-07-15 10:48 ` Alex Riesen
2007-07-15 11:32 ` Marco Costalba
2007-07-15 12:29 ` Marco Costalba
2007-07-15 12:35 ` Sean
2007-07-15 14:58 ` Marco Costalba
2007-07-15 15:04 ` Sean
2007-07-15 15:58 ` Marco Costalba
2007-07-15 16:16 ` Sean
2007-07-15 16:27 ` Marco Costalba
2007-07-15 16:34 ` Sean [this message]
2007-07-15 16:54 ` Marco Costalba
2007-07-15 18:14 ` Linus Torvalds
2007-07-15 18:45 ` Marco Costalba
2007-07-16 12:04 ` Marco Costalba
2007-07-16 12:31 ` Alex Riesen
2007-07-16 17:50 ` Junio C Hamano
2007-07-16 17:55 ` Marco Costalba
2007-07-16 18:02 ` Marco Costalba
2007-07-16 22:37 ` Junio C Hamano
2007-07-16 17:50 ` Marco Costalba
2007-07-17 7:49 ` Andy Parkins
2007-07-17 16:36 ` Marco Costalba
2007-07-25 4:03 ` Junio C Hamano
2007-07-25 9:38 ` Marco Costalba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070715123422.9a431506.seanlkml@sympatico.ca \
--to=seanlkml@sympatico.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mcostalba@gmail.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).