From: Thomas Glanzmann <thomas@glanzmann.de>
To: Scott Lamb <slamb@slamb.org>
Cc: GIT <git@vger.kernel.org>
Subject: Re: [PATCH] Do _not_ call unlink on a directory
Date: Mon, 16 Jul 2007 21:56:00 +0200 [thread overview]
Message-ID: <20070716195600.GC16878@cip.informatik.uni-erlangen.de> (raw)
In-Reply-To: <469BC17D.60806@slamb.org>
Hello,
> If arbitrary other tasks are running, the only way to be absolutely
> certain you're not calling unlink() in a directory is to never call
> unlink().
there is one way to do it safe but it is so ugly that it is
unacceptable: don't call unlink as a privileged user (eg. root). So I
hope that one of the patches make it into git soon. I like the second
patch better because it does less system calls. Not that it matters.
For my co-workers I already build a git version with the patch in so
that they can continue to work as root. Don't even think about asking.
Thomas
next prev parent reply other threads:[~2007-07-16 19:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 17:12 [PATCH] Do _not_ call unlink on a directory Thomas Glanzmann
2007-07-16 17:18 ` Matthieu Moy
2007-07-16 19:05 ` Scott Lamb
2007-07-16 19:56 ` Thomas Glanzmann [this message]
2007-07-16 20:00 ` Thomas Glanzmann
2007-07-16 20:21 ` Linus Torvalds
2007-07-16 20:25 ` Thomas Glanzmann
2007-07-16 20:34 ` Linus Torvalds
2007-07-16 20:39 ` Thomas Glanzmann
2007-07-16 21:23 ` Scott Lamb
2007-07-16 21:44 ` Linus Torvalds
2007-07-16 21:58 ` Scott Lamb
2007-07-16 22:03 ` Linus Torvalds
2007-07-16 20:29 ` Linus Torvalds
2007-07-16 17:38 ` Thomas Glanzmann
2007-07-16 17:41 ` Jan-Benedict Glaw
2007-07-16 17:42 ` Brian Downing
2007-07-16 17:55 ` Thomas Glanzmann
2007-07-16 19:58 ` Linus Torvalds
2007-07-16 21:06 ` Brian Downing
2007-07-16 21:19 ` Linus Torvalds
2007-07-17 8:58 ` David Kastrup
2007-07-17 7:30 ` Junio C Hamano
2007-07-17 8:28 ` Junio C Hamano
2007-07-17 10:15 ` Thomas Glanzmann
2007-07-17 18:34 ` Junio C Hamano
2007-07-17 20:27 ` Thomas Glanzmann
2007-07-18 7:24 ` Johannes Sixt
2007-07-18 8:50 ` Thomas Glanzmann
2007-07-17 19:07 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070716195600.GC16878@cip.informatik.uni-erlangen.de \
--to=thomas@glanzmann.de \
--cc=git@vger.kernel.org \
--cc=slamb@slamb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).