* [PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s).
@ 2007-07-17 17:02 Richard MUSIL
2007-07-17 19:55 ` Eric Wong
0 siblings, 1 reply; 4+ messages in thread
From: Richard MUSIL @ 2007-07-17 17:02 UTC (permalink / raw)
To: git
Changed filter for username in svn-authors file, so even 'user name' is accepted.
---
git-svn.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 01c3904..975075e 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -740,7 +740,7 @@ sub load_authors {
my $log = $cmd eq 'log';
while (<$authors>) {
chomp;
- next unless /^(\S+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
+ next unless /^(\.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
my ($user, $name, $email) = ($1, $2, $3);
if ($log) {
$Git::SVN::Log::rusers{"$name <$email>"} = $user;
--
1.5.1.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s).
2007-07-17 17:02 [PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s) Richard MUSIL
@ 2007-07-17 19:55 ` Eric Wong
2007-07-18 7:36 ` Eric Wong
2007-07-18 8:47 ` Richard MUSIL
0 siblings, 2 replies; 4+ messages in thread
From: Eric Wong @ 2007-07-17 19:55 UTC (permalink / raw)
To: Richard MUSIL; +Cc: git
Richard MUSIL <richard.musil@st.com> wrote:
> Changed filter for username in svn-authors file, so even 'user name' is accepted.
> ---
> git-svn.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 01c3904..975075e 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -740,7 +740,7 @@ sub load_authors {
> my $log = $cmd eq 'log';
> while (<$authors>) {
> chomp;
> - next unless /^(\S+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
> + next unless /^(\.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
Surely you mean the following:
+ next unless /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
(No "\" before the ".") "\." matches a dot/period (.), while "."
matches anything.
--
Eric Wong
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s).
2007-07-17 19:55 ` Eric Wong
@ 2007-07-18 7:36 ` Eric Wong
2007-07-18 8:47 ` Richard MUSIL
1 sibling, 0 replies; 4+ messages in thread
From: Eric Wong @ 2007-07-18 7:36 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Richard MUSIL, git
Eric Wong <eric@petta-tech.com> wrote:
> Richard MUSIL <richard.musil@st.com> wrote:
> > Changed filter for username in svn-authors file, so even 'user name' is accepted.
> > ---
> > git-svn.perl | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/git-svn.perl b/git-svn.perl
> > index 01c3904..975075e 100755
> > --- a/git-svn.perl
> > +++ b/git-svn.perl
> > @@ -740,7 +740,7 @@ sub load_authors {
> > my $log = $cmd eq 'log';
> > while (<$authors>) {
> > chomp;
> > - next unless /^(\S+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
> > + next unless /^(\.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
>
> Surely you mean the following:
>
> + next unless /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
>
> (No "\" before the ".") "\." matches a dot/period (.), while "."
> matches anything.
Fwiw, with the regexp corrected:
Acked-by: Eric Wong <normalperson@yhbt.net>
--
Eric Wong
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s).
2007-07-17 19:55 ` Eric Wong
2007-07-18 7:36 ` Eric Wong
@ 2007-07-18 8:47 ` Richard MUSIL
1 sibling, 0 replies; 4+ messages in thread
From: Richard MUSIL @ 2007-07-18 8:47 UTC (permalink / raw)
To: git
Eric Wong wrote:
> Richard MUSIL <richard.musil@st.com> wrote:
>> Changed filter for username in svn-authors file, so even 'user name' is accepted.
>> ---
>> git-svn.perl | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/git-svn.perl b/git-svn.perl
>> index 01c3904..975075e 100755
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -740,7 +740,7 @@ sub load_authors {
>> my $log = $cmd eq 'log';
>> while (<$authors>) {
>> chomp;
>> - next unless /^(\S+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
>> + next unless /^(\.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
>
> Surely you mean the following:
>
> + next unless /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
>
> (No "\" before the ".") "\." matches a dot/period (.), while "."
> matches anything.
>
Yes! I am sorry for a confusion, I have tested it on '.' version, but committed the wrong one :(.
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-18 8:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-17 17:02 [PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s) Richard MUSIL
2007-07-17 19:55 ` Eric Wong
2007-07-18 7:36 ` Eric Wong
2007-07-18 8:47 ` Richard MUSIL
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).