From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: Adam Roben <aroben@apple.com>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH (REVISED)] Add core.editor configuration variable
Date: Thu, 19 Jul 2007 08:48:51 +0100 [thread overview]
Message-ID: <200707190848.54655.andyparkins@gmail.com> (raw)
In-Reply-To: <11848281302504-git-send-email-aroben@apple.com>
On Thursday 2007 July 19, Adam Roben wrote:
> Well, it turns out we already do launch an editor in other places,
> namely "git am -i" and "git send-email --compose". So, this patch takes
> care of those cases as well.
Perhaps I'm being overly pedantic, but it seems odd to put options that are
relevant only to porcelain under the "core" section.
core.pager is in the same category - but that's already in.
Would porcelain.editor be a better name for this variable?
Andy
--
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
next prev parent reply other threads:[~2007-07-19 7:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 6:55 [PATCH (REVISED)] Add core.editor configuration variable Adam Roben
2007-07-19 7:48 ` Andy Parkins [this message]
2007-07-19 10:00 ` Johannes Schindelin
2007-07-19 10:48 ` Andy Parkins
2007-07-19 11:15 ` Johannes Schindelin
2007-07-19 14:23 ` Andy Parkins
2007-07-19 19:28 ` Nicolas Pitre
2007-07-19 14:24 ` Brian Gernhardt
2007-07-19 14:52 ` Andy Parkins
2007-07-19 19:32 ` Nicolas Pitre
2007-07-20 0:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707190848.54655.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=aroben@apple.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).