git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: Marco Costalba <mcostalba@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Avoid to duplicate commit message when is not encoded
Date: Sun, 22 Jul 2007 10:52:25 +0200	[thread overview]
Message-ID: <20070722085225.GB3408@steel.home> (raw)
In-Reply-To: <e5bfff550707220123g5826cbf5n3e2ff7256d9b5366@mail.gmail.com>

Marco Costalba, Sun, Jul 22, 2007 10:23:05 +0200:
> +		if (encoding) // we'll strip encoding header later

You better avoid using C++ comments, not all C compilers support them.

> +		else
> +			return NULL; // nothing to do

And you better avoid such useless comments too

  parent reply	other threads:[~2007-07-22  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-22  8:23 [PATCH] Avoid to duplicate commit message when is not encoded Marco Costalba
2007-07-22  8:40 ` Junio C Hamano
2007-07-22  8:52 ` Alex Riesen [this message]
2007-07-22  9:17   ` Junio C Hamano
2007-07-22 22:04     ` Marco Costalba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070722085225.GB3408@steel.home \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mcostalba@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).