* [PATCH] Fix update-po target to call msgmerge with right parameters
@ 2007-07-22 10:19 Alex Riesen
2007-07-22 11:48 ` Johannes Schindelin
0 siblings, 1 reply; 2+ messages in thread
From: Alex Riesen @ 2007-07-22 10:19 UTC (permalink / raw)
To: git; +Cc: Johannes Schindelin, Shawn O. Pearce
Add accidentally forgotten semicolon at the end of msgmerge command line
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 52975a7..2c9b3ad 100644
--- a/Makefile
+++ b/Makefile
@@ -113,7 +113,7 @@ ALL_MSGFILES = $(subst .po,.msg,$(ALL_POFILES))
$(PO_TEMPLATE): $(SCRIPT_SH) $(ALL_LIBFILES)
$(XGETTEXT) -kmc -LTcl -o $@ $(SCRIPT_SH) $(ALL_LIBFILES)
update-po:: $(PO_TEMPLATE)
- $(foreach p, $(ALL_POFILES), echo Updating $p ; msgmerge -U $p $(PO_TEMPLATE) )
+ $(foreach p, $(ALL_POFILES), echo Updating $p ; msgmerge -U $p $(PO_TEMPLATE) ; )
$(ALL_MSGFILES): %.msg : %.po
@echo Generating catalog $@
msgfmt --statistics --tcl $< -l $(basename $(notdir $<)) -d $(dir $@)
--
1.5.3.rc2.37.g67fa
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix update-po target to call msgmerge with right parameters
2007-07-22 10:19 [PATCH] Fix update-po target to call msgmerge with right parameters Alex Riesen
@ 2007-07-22 11:48 ` Johannes Schindelin
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2007-07-22 11:48 UTC (permalink / raw)
To: Alex Riesen; +Cc: git, Shawn O. Pearce
Hi,
On Sun, 22 Jul 2007, Alex Riesen wrote:
> Add accidentally forgotten semicolon at the end of msgmerge command line
Good catch!
I did a "make update-po" to test before and after your patch. There seem
to be some changes, but the worst part of it: update-po rewrites almost
the whole file! The .po files contain the line numbers where the message
was found, and they often change.
Oh, well. I'll probably write some alias to see what _actually_
changed (probably just ignoring ^#)...
Ciao,
Dscho
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-22 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-22 10:19 [PATCH] Fix update-po target to call msgmerge with right parameters Alex Riesen
2007-07-22 11:48 ` Johannes Schindelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).