git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: Jason Sewall <jasonsewall@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: Test #7 in t9200-git-cvsexportcommit fails
Date: Sun, 22 Jul 2007 23:42:24 +0200	[thread overview]
Message-ID: <20070722214224.GA2732@steel.home> (raw)
In-Reply-To: <31e9dd080707221349g40ff050bue72733f270822603@mail.gmail.com>

Jason Sewall, Sun, Jul 22, 2007 22:49:19 +0200:
> >It'll never work, cvs does not commit changes made during one second,
> >as they have the same timestamp.
> 
> Why not add a delay in there, like this:
> 
> id=$(git rev-list --max-count=1 HEAD) && sleep 2
> 
> It makes the test work for me.

It looks just like another reason to disable it. It is not like the
_git_ functionality which is used by git-cvsexportcommit is not
already tested elsewhere.

Note that I do _NOT_ suggest disabling it by default, but a bit of
warning would probably do some good:

diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh
index 4efa0c9..e5e9e36 100755
--- a/t/t9200-git-cvsexportcommit.sh
+++ b/t/t9200-git-cvsexportcommit.sh
@@ -6,6 +6,12 @@ test_description='CVS export comit. '
 
 . ./test-lib.sh
 
+echo >&2
+echo >&2 "This test is very timing dependent and may fail."
+echo >&2 "If you don't need git-cvsexportcommit you're better off"
+echo >&2 "disabling it: make test GIT_SKIP_TESTS=t9200"
+echo >&2
+
 cvs >/dev/null 2>&1
 if test $? -ne 1
 then

  reply	other threads:[~2007-07-22 21:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-22 19:41 Test #7 in t9200-git-cvsexportcommit fails Jason Sewall
2007-07-22 20:21 ` Alex Riesen
2007-07-22 20:49   ` Jason Sewall
2007-07-22 21:42     ` Alex Riesen [this message]
2007-07-22 22:19     ` Junio C Hamano
2007-07-23  3:59       ` [PATCH] Add a 1-second sleep to git-cvsexportcommit test Jason Sewall
2007-07-23  4:32         ` Junio C Hamano
2007-07-23  7:55           ` Simon 'corecode' Schubert
2007-07-24  0:23             ` Robin Rosenberg
2007-07-24  8:11               ` Simon 'corecode' Schubert
2007-07-24  8:33                 ` Robin Rosenberg
2007-07-24  8:38                   ` Simon 'corecode' Schubert
2007-07-24  9:34                     ` Robin Rosenberg
2007-07-24 10:14                       ` Junio C Hamano
2007-07-24 12:57                         ` Robin Rosenberg
2007-07-24 15:31                           ` Jason Sewall
2007-07-24 19:02                       ` Linus Torvalds
2007-07-24 22:56                         ` Robin Rosenberg
2007-07-24 23:19                           ` Linus Torvalds
2007-07-25  7:35                         ` Andy Parkins
2007-07-25  7:43                           ` Marius Storm-Olsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070722214224.GA2732@steel.home \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jasonsewall@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).