[QGIT4 PATCH 0/6] Some UI Improvements

git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [QGIT4 PATCH 0/6] Some UI Improvements
@ 2007-07-23 20:32 Peter Oberndorfer
  2007-07-20 20:50 ` [QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding Peter Oberndorfer
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Peter Oberndorfer @ 2007-07-23 20:32 UTC (permalink / raw)
  To: git; +Cc: Marco Costalba

Hi,
the initial reason for this patches is that here on my system qgit4 looks like this
http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png
which is a bit suboptimal for viewing patches :-)
this is on a standard qt 4.3 from gentoo

While i was there i removed the same problem in the custom action editor
and removed some unneed empty space

Actually locally i removed even more empty space, like around the main tab view
and inside the main tab view.
If anyone wants me to remove that too, i would be happy to send more patches

[QGIT4 PATCH 1/6] update patchview.ui with new qt designer
	When i edit the .ui files with the QT designer it updates some unrelated parts.
	Because of this i split the update into a separate patch so the real changes are obvious.
	Feel free to collapse them if you want

[QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding
	this fixes the problem from the screenshot above

[QGIT4 PATCH 3/6] update patchview.ui with new qt designer
	same reason as patch 1

[QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox
	fix same problem in custom action editor

[QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view
[QGIT4 PATCH 6/6] remove empty space below button bar in file view
	these remove some more empty space which i personally find useless
	Apply if you like them

If you want i can provide more screenshots of how patches change appearance.

Greetings Peter

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding
  2007-07-23 20:32 [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
@ 2007-07-20 20:50 ` Peter Oberndorfer
  2007-07-20 21:53 ` [QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view Peter Oberndorfer
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 10+ messages in thread
From: Peter Oberndorfer @ 2007-07-20 20:50 UTC (permalink / raw)
  To: git; +Cc: Marco Costalba

else the diff to header will take up half of the vertical space

Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de>
---
 src/patchview.ui |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/patchview.ui b/src/patchview.ui
index a599e09..6dbf53c 100644
--- a/src/patchview.ui
+++ b/src/patchview.ui
@@ -163,6 +163,12 @@
      </item>
      <item>
       <widget class="QSplitter" name="splitter_2" >
+       <property name="sizePolicy" >
+        <sizepolicy vsizetype="Expanding" hsizetype="Expanding" >
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
        <property name="orientation" >
         <enum>Qt::Horizontal</enum>
        </property>
-- 
1.5.3.rc2.30.g1fe72

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view
  2007-07-23 20:32 [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
  2007-07-20 20:50 ` [QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding Peter Oberndorfer
@ 2007-07-20 21:53 ` Peter Oberndorfer
  2007-07-21 13:22 ` [QGIT4 PATCH 6/6] remove empty space below button bar in file view Peter Oberndorfer
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 10+ messages in thread
From: Peter Oberndorfer @ 2007-07-20 21:53 UTC (permalink / raw)
  To: git; +Cc: Marco Costalba

---
 src/patchview.ui |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/patchview.ui b/src/patchview.ui
index 6dbf53c..b4d3081 100644
--- a/src/patchview.ui
+++ b/src/patchview.ui
@@ -31,7 +31,7 @@
    <item>
     <layout class="QVBoxLayout" >
      <property name="spacing" >
-      <number>6</number>
+      <number>0</number>
      </property>
      <property name="leftMargin" >
       <number>0</number>
@@ -131,7 +131,7 @@
          <property name="sizeHint" >
           <size>
            <width>20</width>
-           <height>40</height>
+           <height>0</height>
           </size>
          </property>
         </spacer>
-- 
1.5.3.rc2.30.g1fe72

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [QGIT4 PATCH 6/6] remove empty space below button bar in file view
  2007-07-23 20:32 [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
  2007-07-20 20:50 ` [QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding Peter Oberndorfer
  2007-07-20 21:53 ` [QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view Peter Oberndorfer
@ 2007-07-21 13:22 ` Peter Oberndorfer
  2007-07-21 13:24 ` [QGIT4 PATCH 3/6] update patchview.ui with new qt designer Peter Oberndorfer
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 10+ messages in thread
From: Peter Oberndorfer @ 2007-07-21 13:22 UTC (permalink / raw)
  To: git; +Cc: Marco Costalba

---
 src/fileview.ui |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/fileview.ui b/src/fileview.ui
index 190ed5e..97fa000 100644
--- a/src/fileview.ui
+++ b/src/fileview.ui
@@ -31,7 +31,7 @@
    <item>
     <layout class="QVBoxLayout" >
      <property name="spacing" >
-      <number>6</number>
+      <number>0</number>
      </property>
      <property name="leftMargin" >
       <number>0</number>
-- 
1.5.3.rc2.30.g1fe72

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [QGIT4 PATCH 3/6] update patchview.ui with new qt designer
  2007-07-23 20:32 [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
                   ` (2 preceding siblings ...)
  2007-07-21 13:22 ` [QGIT4 PATCH 6/6] remove empty space below button bar in file view Peter Oberndorfer
@ 2007-07-21 13:24 ` Peter Oberndorfer
  2007-07-21 13:31 ` [QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox Peter Oberndorfer
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 10+ messages in thread
From: Peter Oberndorfer @ 2007-07-21 13:24 UTC (permalink / raw)
  To: git; +Cc: Marco Costalba

---
 src/customaction.ui |  154 ++++++++++++++++++++++++++++++++++++++++-----------
 1 files changed, 121 insertions(+), 33 deletions(-)

diff --git a/src/customaction.ui b/src/customaction.ui
index fc2ceba..59004ca 100644
--- a/src/customaction.ui
+++ b/src/customaction.ui
@@ -16,26 +16,42 @@
    <iconset resource="icons.qrc" >:/icons/resources/bookmark.png</iconset>
   </property>
   <layout class="QHBoxLayout" >
-   <property name="margin" >
-    <number>5</number>
-   </property>
    <property name="spacing" >
     <number>0</number>
    </property>
+   <property name="leftMargin" >
+    <number>5</number>
+   </property>
+   <property name="topMargin" >
+    <number>5</number>
+   </property>
+   <property name="rightMargin" >
+    <number>5</number>
+   </property>
+   <property name="bottomMargin" >
+    <number>5</number>
+   </property>
    <item>
     <layout class="QVBoxLayout" >
-     <property name="margin" >
-      <number>0</number>
-     </property>
      <property name="spacing" >
       <number>6</number>
      </property>
+     <property name="leftMargin" >
+      <number>0</number>
+     </property>
+     <property name="topMargin" >
+      <number>0</number>
+     </property>
+     <property name="rightMargin" >
+      <number>0</number>
+     </property>
+     <property name="bottomMargin" >
+      <number>0</number>
+     </property>
      <item>
       <widget class="QFrame" name="frame" >
        <property name="sizePolicy" >
-        <sizepolicy>
-         <hsizetype>5</hsizetype>
-         <vsizetype>0</vsizetype>
+        <sizepolicy vsizetype="Fixed" hsizetype="Preferred" >
          <horstretch>0</horstretch>
          <verstretch>0</verstretch>
         </sizepolicy>
@@ -47,20 +63,38 @@
         <enum>QFrame::Raised</enum>
        </property>
        <layout class="QHBoxLayout" >
-        <property name="margin" >
-         <number>9</number>
-        </property>
         <property name="spacing" >
          <number>6</number>
         </property>
+        <property name="leftMargin" >
+         <number>9</number>
+        </property>
+        <property name="topMargin" >
+         <number>9</number>
+        </property>
+        <property name="rightMargin" >
+         <number>9</number>
+        </property>
+        <property name="bottomMargin" >
+         <number>9</number>
+        </property>
         <item>
          <layout class="QHBoxLayout" >
-          <property name="margin" >
-           <number>0</number>
-          </property>
           <property name="spacing" >
            <number>15</number>
           </property>
+          <property name="leftMargin" >
+           <number>0</number>
+          </property>
+          <property name="topMargin" >
+           <number>0</number>
+          </property>
+          <property name="rightMargin" >
+           <number>0</number>
+          </property>
+          <property name="bottomMargin" >
+           <number>0</number>
+          </property>
           <item>
            <widget class="QPushButton" name="pushButtonNew" >
             <property name="text" >
@@ -147,20 +181,38 @@
          <enum>QFrame::Raised</enum>
         </property>
         <layout class="QHBoxLayout" >
-         <property name="margin" >
-          <number>9</number>
-         </property>
          <property name="spacing" >
           <number>6</number>
          </property>
+         <property name="leftMargin" >
+          <number>9</number>
+         </property>
+         <property name="topMargin" >
+          <number>9</number>
+         </property>
+         <property name="rightMargin" >
+          <number>9</number>
+         </property>
+         <property name="bottomMargin" >
+          <number>9</number>
+         </property>
          <item>
           <layout class="QVBoxLayout" >
-           <property name="margin" >
-            <number>0</number>
-           </property>
            <property name="spacing" >
             <number>6</number>
            </property>
+           <property name="leftMargin" >
+            <number>0</number>
+           </property>
+           <property name="topMargin" >
+            <number>0</number>
+           </property>
+           <property name="rightMargin" >
+            <number>0</number>
+           </property>
+           <property name="bottomMargin" >
+            <number>0</number>
+           </property>
            <item>
             <widget class="QLabel" name="labelActionName" >
              <property name="text" >
@@ -186,20 +238,38 @@
          <enum>QFrame::Raised</enum>
         </property>
         <layout class="QHBoxLayout" >
-         <property name="margin" >
-          <number>9</number>
-         </property>
          <property name="spacing" >
           <number>6</number>
          </property>
+         <property name="leftMargin" >
+          <number>9</number>
+         </property>
+         <property name="topMargin" >
+          <number>9</number>
+         </property>
+         <property name="rightMargin" >
+          <number>9</number>
+         </property>
+         <property name="bottomMargin" >
+          <number>9</number>
+         </property>
          <item>
           <layout class="QVBoxLayout" >
-           <property name="margin" >
-            <number>0</number>
-           </property>
            <property name="spacing" >
             <number>6</number>
            </property>
+           <property name="leftMargin" >
+            <number>0</number>
+           </property>
+           <property name="topMargin" >
+            <number>0</number>
+           </property>
+           <property name="rightMargin" >
+            <number>0</number>
+           </property>
+           <property name="bottomMargin" >
+            <number>0</number>
+           </property>
            <item>
             <widget class="QLabel" name="textLabel1" >
              <property name="text" >
@@ -219,12 +289,21 @@
            </item>
            <item>
             <layout class="QHBoxLayout" >
-             <property name="margin" >
-              <number>0</number>
-             </property>
              <property name="spacing" >
               <number>6</number>
              </property>
+             <property name="leftMargin" >
+              <number>0</number>
+             </property>
+             <property name="topMargin" >
+              <number>0</number>
+             </property>
+             <property name="rightMargin" >
+              <number>0</number>
+             </property>
+             <property name="bottomMargin" >
+              <number>0</number>
+             </property>
              <item>
               <widget class="QCheckBox" name="checkBoxRefreshAfterAction" >
                <property name="toolTip" >
@@ -261,12 +340,21 @@
      </item>
      <item>
       <layout class="QHBoxLayout" >
-       <property name="margin" >
-        <number>0</number>
-       </property>
        <property name="spacing" >
         <number>6</number>
        </property>
+       <property name="leftMargin" >
+        <number>0</number>
+       </property>
+       <property name="topMargin" >
+        <number>0</number>
+       </property>
+       <property name="rightMargin" >
+        <number>0</number>
+       </property>
+       <property name="bottomMargin" >
+        <number>0</number>
+       </property>
        <item>
         <spacer>
          <property name="orientation" >
-- 
1.5.3.rc2.30.g1fe72

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox
  2007-07-23 20:32 [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
                   ` (3 preceding siblings ...)
  2007-07-21 13:24 ` [QGIT4 PATCH 3/6] update patchview.ui with new qt designer Peter Oberndorfer
@ 2007-07-21 13:31 ` Peter Oberndorfer
  2007-07-22 12:50 ` [QGIT4 PATCH 1/6] update patchview.ui with new qt designer Peter Oberndorfer
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 10+ messages in thread
From: Peter Oberndorfer @ 2007-07-21 13:31 UTC (permalink / raw)
  To: git; +Cc: Marco Costalba

in action setup dialog to expanding
else the empty space with the button below takes up half of the vertical space

Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de>
---
 src/customaction.ui |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/customaction.ui b/src/customaction.ui
index 59004ca..49bb6c7 100644
--- a/src/customaction.ui
+++ b/src/customaction.ui
@@ -170,6 +170,12 @@
      </item>
      <item>
       <widget class="QSplitter" name="splitter" >
+       <property name="sizePolicy" >
+        <sizepolicy vsizetype="Expanding" hsizetype="Expanding" >
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
        <property name="orientation" >
         <enum>Qt::Horizontal</enum>
        </property>
-- 
1.5.3.rc2.30.g1fe72

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [QGIT4 PATCH 1/6] update patchview.ui with new qt designer
  2007-07-23 20:32 [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
                   ` (4 preceding siblings ...)
  2007-07-21 13:31 ` [QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox Peter Oberndorfer
@ 2007-07-22 12:50 ` Peter Oberndorfer
  2007-07-23 20:52 ` [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
  2007-07-23 22:13 ` Marco Costalba
  7 siblings, 0 replies; 10+ messages in thread
From: Peter Oberndorfer @ 2007-07-22 12:50 UTC (permalink / raw)
  To: git; +Cc: Marco Costalba

---
 src/patchview.ui |   57 ++++++++++++++++++++++++++++++++++++-----------------
 1 files changed, 39 insertions(+), 18 deletions(-)

diff --git a/src/patchview.ui b/src/patchview.ui
index 1539242..a599e09 100644
--- a/src/patchview.ui
+++ b/src/patchview.ui
@@ -13,28 +13,55 @@
    <string>Patch</string>
   </property>
   <layout class="QHBoxLayout" >
-   <property name="margin" >
+   <property name="spacing" >
     <number>0</number>
    </property>
-   <property name="spacing" >
+   <property name="leftMargin" >
+    <number>0</number>
+   </property>
+   <property name="topMargin" >
+    <number>0</number>
+   </property>
+   <property name="rightMargin" >
+    <number>0</number>
+   </property>
+   <property name="bottomMargin" >
     <number>0</number>
    </property>
    <item>
     <layout class="QVBoxLayout" >
-     <property name="margin" >
-      <number>0</number>
-     </property>
      <property name="spacing" >
       <number>6</number>
      </property>
+     <property name="leftMargin" >
+      <number>0</number>
+     </property>
+     <property name="topMargin" >
+      <number>0</number>
+     </property>
+     <property name="rightMargin" >
+      <number>0</number>
+     </property>
+     <property name="bottomMargin" >
+      <number>0</number>
+     </property>
      <item>
       <layout class="QHBoxLayout" >
-       <property name="margin" >
-        <number>2</number>
-       </property>
        <property name="spacing" >
         <number>6</number>
        </property>
+       <property name="leftMargin" >
+        <number>2</number>
+       </property>
+       <property name="topMargin" >
+        <number>2</number>
+       </property>
+       <property name="rightMargin" >
+        <number>2</number>
+       </property>
+       <property name="bottomMargin" >
+        <number>2</number>
+       </property>
        <item>
         <widget class="QLabel" name="textLabel" >
          <property name="text" >
@@ -112,9 +139,7 @@
        <item>
         <widget class="QLineEdit" name="lineEditDiff" >
          <property name="sizePolicy" >
-          <sizepolicy>
-           <hsizetype>7</hsizetype>
-           <vsizetype>0</vsizetype>
+          <sizepolicy vsizetype="Fixed" hsizetype="Expanding" >
            <horstretch>1</horstretch>
            <verstretch>0</verstretch>
           </sizepolicy>
@@ -143,9 +168,7 @@
        </property>
        <widget class="QSplitter" name="splitter" >
         <property name="sizePolicy" >
-         <sizepolicy>
-          <hsizetype>5</hsizetype>
-          <vsizetype>7</vsizetype>
+         <sizepolicy vsizetype="Expanding" hsizetype="Preferred" >
           <horstretch>5</horstretch>
           <verstretch>0</verstretch>
          </sizepolicy>
@@ -169,15 +192,13 @@
           <bool>true</bool>
          </property>
          <property name="textInteractionFlags" >
-          <enum>Qt::TextSelectableByMouse</enum>
+          <set>Qt::TextSelectableByMouse</set>
          </property>
         </widget>
        </widget>
        <widget class="FileList" name="fileList" >
         <property name="sizePolicy" >
-         <sizepolicy>
-          <hsizetype>13</hsizetype>
-          <vsizetype>13</vsizetype>
+         <sizepolicy vsizetype="Ignored" hsizetype="Ignored" >
           <horstretch>1</horstretch>
           <verstretch>0</verstretch>
          </sizepolicy>
-- 
1.5.3.rc2.30.g1fe72

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [QGIT4 PATCH 0/6] Some UI Improvements
  2007-07-23 20:32 [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
                   ` (5 preceding siblings ...)
  2007-07-22 12:50 ` [QGIT4 PATCH 1/6] update patchview.ui with new qt designer Peter Oberndorfer
@ 2007-07-23 20:52 ` Peter Oberndorfer
  2007-07-23 22:13 ` Marco Costalba
  7 siblings, 0 replies; 10+ messages in thread
From: Peter Oberndorfer @ 2007-07-23 20:52 UTC (permalink / raw)
  To: git; +Cc: Marco Costalba

On Monday 23 July 2007 22:32, Peter Oberndorfer wrote:
> Hi,
> the initial reason for this patches is that here on my system qgit4 looks like this
> http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png
> which is a bit suboptimal for viewing patches :-)
> this is on a standard qt 4.3 from gentoo
> 
> While i was there i removed the same problem in the custom action editor
> and removed some unneed empty space
> 
> Actually locally i removed even more empty space, like around the main tab view
> and inside the main tab view.
> If anyone wants me to remove that too, i would be happy to send more patches
> 
> [QGIT4 PATCH 1/6] update patchview.ui with new qt designer
> 	When i edit the .ui files with the QT designer it updates some unrelated parts.
> 	Because of this i split the update into a separate patch so the real changes are obvious.
> 	Feel free to collapse them if you want
> 
> [QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding
> 	this fixes the problem from the screenshot above
> 
> [QGIT4 PATCH 3/6] update patchview.ui with new qt designer
> 	same reason as patch 1
> 
> [QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox
> 	fix same problem in custom action editor
> 
> [QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view
> [QGIT4 PATCH 6/6] remove empty space below button bar in file view
> 	these remove some more empty space which i personally find useless
> 	Apply if you like them
> 
> If you want i can provide more screenshots of how patches change appearance.
> 
> Greetings Peter
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
hmm, kmail moved Signed-off-by in patches to mail headers,
because there was no message text before it.

so here is a
Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de>
for all my qgit patches

Greetings Peter

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [QGIT4 PATCH 0/6] Some UI Improvements
  2007-07-23 20:32 [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
                   ` (6 preceding siblings ...)
  2007-07-23 20:52 ` [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
@ 2007-07-23 22:13 ` Marco Costalba
  2007-07-24 17:29   ` Peter Oberndorfer
  7 siblings, 1 reply; 10+ messages in thread
From: Marco Costalba @ 2007-07-23 22:13 UTC (permalink / raw)
  To: Peter Oberndorfer; +Cc: git

On 7/23/07, Peter Oberndorfer <kumbayo84@arcor.de> wrote:
> Hi,
> the initial reason for this patches is that here on my system qgit4 looks like this
> http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png

Hi Peter,

OMG that's horrific! I can't understand how it is possible, on my box
(Mandriva with QT4.3) everything is fine.

Anyway thanks a lot for the patches. Already applied and pushed.

 > If anyone wants me to remove that too, i would be happy to send more patches

Please feel free to send me any patch that could improve the GUI,
unfortunately on my box I'm unable to see all these defects, so any
patch from you is more then welcome.

>
> If you want i can provide more screenshots of how patches change appearance.
>

Patchview has not changed for me with your patches, fileview yes, I
can see the difference and also customaction. I would say nice job!
thanks.

 Marco

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [QGIT4 PATCH 0/6] Some UI Improvements
  2007-07-23 22:13 ` Marco Costalba
@ 2007-07-24 17:29   ` Peter Oberndorfer
  0 siblings, 0 replies; 10+ messages in thread
From: Peter Oberndorfer @ 2007-07-24 17:29 UTC (permalink / raw)
  To: Marco Costalba; +Cc: git

On Tuesday 24 July 2007 00:13, Marco Costalba wrote:
> On 7/23/07, Peter Oberndorfer <kumbayo84@arcor.de> wrote:
> > Hi,
> > the initial reason for this patches is that here on my system qgit4 looks like this
> > http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png
> 
> Hi Peter,
> 
> OMG that's horrific! I can't understand how it is possible, on my box
> (Mandriva with QT4.3) everything is fine.
> 
> Anyway thanks a lot for the patches. Already applied and pushed.
Thanks for applying.
> 
>  > If anyone wants me to remove that too, i would be happy to send more patches
> 
> Please feel free to send me any patch that could improve the GUI,
> unfortunately on my box I'm unable to see all these defects, so any
> patch from you is more then welcome.
Will send them when they are cleaned up properly.
> 
> >
> > If you want i can provide more screenshots of how patches change appearance.
> >
> 
> Patchview has not changed for me with your patches, fileview yes, I
> can see the difference and also customaction. I would say nice job!
> thanks.
Without patch 5 (remove empty space below "diff to" header in patch view)
qgit4 looks like this on my machine
http://img409.imageshack.us/img409/5174/qgitwithoutpatch5zp9.png

Greetings Peter
> 
>  Marco
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2007-07-24 17:32 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-23 20:32 [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
2007-07-20 20:50 ` [QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding Peter Oberndorfer
2007-07-20 21:53 ` [QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view Peter Oberndorfer
2007-07-21 13:22 ` [QGIT4 PATCH 6/6] remove empty space below button bar in file view Peter Oberndorfer
2007-07-21 13:24 ` [QGIT4 PATCH 3/6] update patchview.ui with new qt designer Peter Oberndorfer
2007-07-21 13:31 ` [QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox Peter Oberndorfer
2007-07-22 12:50 ` [QGIT4 PATCH 1/6] update patchview.ui with new qt designer Peter Oberndorfer
2007-07-23 20:52 ` [QGIT4 PATCH 0/6] Some UI Improvements Peter Oberndorfer
2007-07-23 22:13 ` Marco Costalba
2007-07-24 17:29   ` Peter Oberndorfer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).