git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Timo Hirvonen <tihirvon@gmail.com>
To: Johannes Sixt <johannes.sixt@telecom.at>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Fix problematic ']'
Date: Mon, 23 Jul 2007 23:58:35 +0300	[thread overview]
Message-ID: <20070723235835.36b6d87a.tihirvon@gmail.com> (raw)
In-Reply-To: <200707232236.21389.johannes.sixt@telecom.at>

Johannes Sixt <johannes.sixt@telecom.at> wrote:

> Not all shells grok a closing ']' of the shell '[' command without
> surrounding space.

That's one good reason to use test instead of /usr/bin/[ hack (yes it
has been a shell built-in for a long time). [ is just like test but
expects ] as last parameter and ignores it.  Very ugly IMO.

-- 
http://onion.dynserv.net/~timo/

  parent reply	other threads:[~2007-07-23 20:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-23 20:36 [PATCH] Fix problematic ']' Johannes Sixt
2007-07-23 20:51 ` Johannes Schindelin
2007-07-23 20:58 ` Timo Hirvonen [this message]
2007-07-24  2:01 ` Junio C Hamano
2007-07-24  2:18   ` [PATCH] rebase -i: exchange all "if [ .. ]" by "if test .." Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070723235835.36b6d87a.tihirvon@gmail.com \
    --to=tihirvon@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=johannes.sixt@telecom.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).