From: Thomas Schwinge <tschwinge@gnu.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Don't rely on unspecified behavior
Date: Sat, 28 Jul 2007 21:43:06 +0200 [thread overview]
Message-ID: <20070728194306.GA32203@fencepost.gnu.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0707282028130.14781@racer.site>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
Hello!
On Sat, Jul 28, 2007 at 08:30:07PM +0100, Johannes Schindelin wrote:
> On Sat, 28 Jul 2007, Thomas Schwinge wrote:
> > Calling access(p, m) with p == NULL is not specified, so don't do that. On
> > GNU/Hurd systems doing so will result in a SIGSEGV.
> >
> > Signed-off-by: Thomas Schwinge <tschwinge@gnu.org>
> > ---
>
> Isn't this the same patch as you sent before?
As I wrote in <20070728182542.GA22651@fencepost.gnu.org>: ``I noticed
that the patch I sent was prepared for an old version of the file. I'll
send an updated patch that applies to the current revision.''
> > + if (excludes_file != NULL && !access(excludes_file, R_OK))
>
> We usually omit the "!= NULL"; see the other source code in git.git.
Okay, so I should sent a thusly modified version to get it applied?
Regards,
Thomas
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 191 bytes --]
next prev parent reply other threads:[~2007-07-28 19:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-28 16:39 [PATCH] Support building on GNU/Hurd Thomas Schwinge
2007-07-28 16:39 ` [PATCH] Don't rely on unspecified behavior Thomas Schwinge
2007-07-28 17:39 ` Thomas Glanzmann
2007-07-28 18:25 ` Thomas Schwinge
2007-07-28 18:26 ` Thomas Schwinge
2007-07-28 19:30 ` Johannes Schindelin
2007-07-28 19:34 ` Thomas Glanzmann
2007-07-28 20:16 ` Johannes Schindelin
2007-07-28 20:20 ` Thomas Glanzmann
2007-07-28 19:43 ` Thomas Schwinge [this message]
2007-07-28 20:17 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070728194306.GA32203@fencepost.gnu.org \
--to=tschwinge@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).