git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sean <seanlkml@sympatico.ca>,
	Benoit SIGOURE <tsuna@lrde.epita.fr>,
	git@vger.kernel.org
Subject: Re: git-svn rebase screwing up commit messages
Date: Sat, 28 Jul 2007 21:48:12 +0200	[thread overview]
Message-ID: <200707282148.13751.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <7vk5skps1g.fsf@assigned-by-dhcp.cox.net>

lördag 28 juli 2007 skrev Junio C Hamano:
> Sean <seanlkml@sympatico.ca> writes:
> 
> >> Having said all that, so that the readers understand the
> >> background, here is a not-so-heavily-tested patch, which might
> >> help.  It passes all the test suite as before, but that tells
> >> how existing git-svn tests do not test many things.
> >> 
> >> I am not considering this for inclusion right now, by the way.
> >
> > FWIW your patch fixed my test case here.
> 
> Actually the patched behaviour actively encourages a bad (not in
> the sense that those oneline tools will not work well, but in
> the sense that these messages are reader unfriendly) practice; I
> do not think what the patch did deserves to be called "fixed".

git-svn should not enforce git conventions when managing commits
intended for svn. Those commits should obviously follow the conventions
for the target (svn) repo. 

-- robin

  parent reply	other threads:[~2007-07-28 19:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-28 10:07 git-svn rebase screwing up commit messages Benoit SIGOURE
2007-07-28 12:14 ` Junio C Hamano
2007-07-28 12:35   ` Sean
2007-07-28 13:10     ` Junio C Hamano
2007-07-28 13:29       ` Sean
2007-07-28 13:38         ` Junio C Hamano
2007-07-28 14:11           ` Sean
2007-07-28 20:41             ` Junio C Hamano
2007-07-29  1:08               ` Junio C Hamano
2007-07-29  1:10                 ` [PATCH 1/3] log_ref_write() -- do not chomp reflog message at the first LF Junio C Hamano
2007-07-29 11:57                   ` Johannes Schindelin
2007-07-29 18:47                     ` Junio C Hamano
2007-07-29 19:02                       ` Johannes Schindelin
2007-07-29  1:10                 ` [PATCH 2/3] symbolic-ref, update-ref: do not refuse reflog message with LF Junio C Hamano
2007-07-29  1:11                 ` [PATCH 3/3] rebase: try not to munge commit log message Junio C Hamano
2007-07-28 14:32           ` git-svn rebase screwing up commit messages Jakub Narebski
2007-07-28 19:48           ` Robin Rosenberg [this message]
2007-07-28 17:33       ` Benoit SIGOURE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707282148.13751.robin.rosenberg.lists@dewire.com \
    --to=robin.rosenberg.lists@dewire.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=seanlkml@sympatico.ca \
    --cc=tsuna@lrde.epita.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).