From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: David Kastrup <dak@gnu.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: "git stash" is not known to git
Date: Mon, 30 Jul 2007 06:04:08 -0400 [thread overview]
Message-ID: <20070730100408.GA8829@coredump.intra.peff.net> (raw)
In-Reply-To: <vpqwswi2pkw.fsf@bauges.imag.fr>
On Mon, Jul 30, 2007 at 11:44:31AM +0200, Matthieu Moy wrote:
> > One has to use git-stash rather than "git stash". Oversight?
>
> This looks like an incorrect installation, with git-stash in your
> $PATH, but not in the place git looks for its commands (I don't
> remember the exact mechanism).
On a related note, is it just me, or is the following comment and related code
in git.c (introduced by Linus in 231af832) totally bogus:
/*
* We search for git commands in the following order:
* - git_exec_path()
* - the path of the "git" command if we could find it
* in $0
* - the regular PATH.
*/
We never actually look in the regular PATH since we call execv_git_cmd
(although we do still munge the PATH, apparently so shell scripts can
use git-foo syntax; see 77cb17e9). This means you can't drop "git-foo"
into your PATH and have it work as "git foo".
What is the desired behavior?
-Peff
next prev parent reply other threads:[~2007-07-30 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 9:22 "git stash" is not known to git David Kastrup
2007-07-30 9:44 ` Matthieu Moy
2007-07-30 9:57 ` David Kastrup
2007-07-30 10:06 ` Jeff King
2007-07-30 10:24 ` David Kastrup
2007-07-30 10:37 ` Jeff King
2007-07-30 10:52 ` David Kastrup
2007-07-30 11:03 ` Jeff King
2007-07-30 19:30 ` David Kastrup
2007-07-30 10:04 ` Jeff King [this message]
2007-07-30 17:52 ` Junio C Hamano
2007-07-31 8:20 ` Junio C Hamano
2007-07-31 13:52 ` Jeff King
2007-07-30 10:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730100408.GA8829@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).