From: Jeff King <peff@peff.net>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/4] Fix allocation of "int*" instead of "int".
Date: Tue, 31 Jul 2007 15:56:16 -0400 [thread overview]
Message-ID: <20070731195616.GA6329@sigill.intra.peff.net> (raw)
In-Reply-To: <20070731144829.ea83d43d.chriscool@tuxfamily.org>
On Tue, Jul 31, 2007 at 02:48:29PM +0200, Christian Couder wrote:
> - weights = xcalloc(on_list, sizeof(int*));
> + weights = xcalloc(on_list, sizeof(int));
How about the correct-by-definition sizeof(*weights)?
-Peff
next prev parent reply other threads:[~2007-07-31 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 12:48 [PATCH 1/4] Fix allocation of "int*" instead of "int" Christian Couder
2007-07-31 19:56 ` Jeff King [this message]
2007-08-01 4:11 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070731195616.GA6329@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).