From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view
Date: Thu, 2 Aug 2007 12:47:07 +0200 [thread overview]
Message-ID: <200708021247.08612.jnareb@gmail.com> (raw)
In-Reply-To: <7vtzri1pfi.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Personally, this late in the game, I would be more interested in
> resolving the File::Find() stuff, which has been a real issue in
> the field, than the compressed transfer one.
I posted my tentative Ack, haven't I?
I guess that your solution is good, and doesn't have any drawbacks,
besides perhaps a tiny little bit of lost performance. So I think
that you should just commit this...
As to the new stuff: I think I postpone large changes, like blob
size in tree view, or links to no merges and first parent
log/shortlog/history view, or list form of two pipelines we have in
gitweb, or HTML cleanup, etc. after the v1.5.3 release.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2007-08-02 18:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 11:19 [PATCH 1/2] gitweb: Allow for multivalued parameters passed to href subroutine Jakub Narebski
2007-07-31 11:19 ` [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view Jakub Narebski
2007-07-31 22:12 ` Junio C Hamano
2007-08-01 13:05 ` Jakub Narebski
2007-08-01 23:12 ` Junio C Hamano
2007-08-01 23:58 ` Jakub Narebski
2007-08-02 0:47 ` Junio C Hamano
2007-08-02 5:22 ` Junio C Hamano
2007-08-02 10:47 ` Jakub Narebski [this message]
2007-08-02 20:47 ` Junio C Hamano
2007-07-31 23:07 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708021247.08612.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).