git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Miles Bader <miles@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: way to automatically add untracked files?
Date: Sat, 4 Aug 2007 23:58:54 -0400	[thread overview]
Message-ID: <20070805035854.GF9527@spearce.org> (raw)
In-Reply-To: <873ayymzc1.fsf@catnip.gol.com>

Miles Bader <miles@gnu.org> wrote:
> One way to do this seems to be just "git add .", but I'm always slightly
> nervous using it because it sits there and churns the disk for an awful
> long time (whereas "git status" is instantaneous).  Is this the right
> thing to do?  Is there something funny causing the churning?

That's the correct way to add those new files that aren't ignored.
The problem is actually a small bug in git-add; we did not take the
obvious performance optimization of skipping files that are stat
clean in the index.  So what is happening here during `git add .`
is we are reading and hashing every single file, even if it is
already tracked and is not modified.  In short we're just working
harder than we need to during this operation.

I believe this has been fixed in git 1.5.3-rc3 or rc4.  Not sure
which one; I don't have access to a git repository right now to
look it up.

-- 
Shawn.

  reply	other threads:[~2007-08-05  3:59 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-05  3:31 way to automatically add untracked files? Miles Bader
2007-08-05  3:58 ` Shawn O. Pearce [this message]
2007-08-05  4:13   ` Junio C Hamano
2007-08-05  4:00 ` Miles Bader
2007-08-05  4:13   ` Shawn O. Pearce
2007-08-05  4:22     ` Miles Bader
2007-08-05  4:23       ` Junio C Hamano
2007-08-05  4:30         ` Miles Bader
2007-08-05  4:39           ` Junio C Hamano
2007-08-05  4:53             ` Miles Bader
2007-08-05  5:04               ` Junio C Hamano
2007-08-05  5:17                 ` Miles Bader
2007-08-05  5:23                   ` Johannes Schindelin
2007-08-05  5:27                     ` Miles Bader
2007-08-05 11:22             ` Steffen Prohaska
2007-08-05 12:11     ` Johan Herland
2007-08-05 12:17       ` David Kastrup
2007-08-05 16:11       ` Theodore Tso
2007-08-05 19:16         ` Johan Herland
2007-08-06  0:00           ` Miles Bader
2007-08-06  0:16           ` Johannes Schindelin
2007-08-06  3:09             ` Miles Bader
2007-08-06  3:21               ` Johannes Schindelin
2007-08-06  3:45                 ` Miles Bader
2007-08-06  7:46                 ` Johan Herland
2007-08-06 12:17                   ` Johannes Schindelin
2007-08-05 20:04         ` Steffen Prohaska
2007-08-06  0:17           ` Johannes Schindelin
2007-08-06  4:58             ` Steffen Prohaska
2007-08-06  0:32       ` Jakub Narebski
2007-08-06  7:30         ` Johan Herland
2007-08-06  8:45     ` Junio C Hamano
2007-08-06 18:19       ` David Kastrup
2007-08-07  0:08         ` Miles Bader
2007-08-05  5:03   ` Linus Torvalds
2007-08-05  5:14     ` Junio C Hamano
2007-08-05  7:32       ` David Kastrup
2007-08-05 10:33         ` Benchmarking git-add vs git-ls-files+update-index (was: way to automatically add untracked files?) David Kastrup
2007-08-05  7:34     ` way to automatically add untracked files? Miles Bader
2007-08-05 17:04       ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070805035854.GF9527@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).