From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: Gerrit Pape <pape@smarden.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] post-receive-email hook: handle order of arguments consistently
Date: Tue, 7 Aug 2007 18:38:15 +0100 [thread overview]
Message-ID: <200708071838.17999.andyparkins@gmail.com> (raw)
In-Reply-To: <20070807135849.24926.qmail@49810ee852ce6e.315fe32.mid.smarden.org>
On Tuesday 2007, August 07, Gerrit Pape wrote:
> The post-receive-email hook usually gets its arguments through stdin,
> but also supports them to be specified at the command line. The order
> of the arguments should consistently follow the documentation no matter
> how they are passed to the script.
As I said the last time this was posted, this was done on purpose so that
the command line arguments match the order of the arguments to the update
hook.
Keeping them in that order allows the script to be used as an update hook in
older versions of git.
Whether that is sensible or not is for Junio and the gang to decide; but
there was good reason for doing it that way. Also, I'm not sure what
documentation you're talking about - use in command line mode is a bonus
feature anyway, it's not necessary in normal hook mode anyway. If you're
going to be strict about matching documentation then the command line mode
should be removed.
Andy
--
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
prev parent reply other threads:[~2007-08-07 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 9:09 [PATCH] post-receive-email hook: handle order of arguments consistently Gerrit Pape
2007-06-14 10:19 ` Andy Parkins
2007-08-07 13:58 ` Gerrit Pape
2007-08-07 17:38 ` Andy Parkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708071838.17999.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).