From: Jan Hudec <bulb@ucw.cz>
To: Thomas Adam <thomas.adam22@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Template commit messages.
Date: Wed, 8 Aug 2007 18:24:11 +0200 [thread overview]
Message-ID: <20070808162411.GA4884@efreet.light.src> (raw)
In-Reply-To: <18071eea0708050532x2d9bfddw96a9428f4840b1fc@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2822 bytes --]
On Sun, Aug 05, 2007 at 13:32:48 +0100, Thomas Adam wrote:
> Am I correct in thinking that the new template messages that will be
> in the up and coming git release will alleviate an "annoyance" I've
> currently got with commit messages?
Reading the description below, I really doubt that. The templates are to
*add* stuff, not to remove it.
> Basically, I want a way of removing what is now, a long list of
> untracked files from the commit message before it hits the editor --
> I've looked at $GIT_DIR/.git/hooks/{pre,post}-commit as well as:
> $GIT_DIR/.git/hooks/commit-msg in the hopes I could add a sed command
> there to remove the list of files, and whilst the sed command worked
> fine on the command line, adding it to any of those files didn't.
Neither of this commands actually see the list. Because the list is *not*
part of the commit message. It is a comment, which is added just before the
editor is started and stripped right afterwards.
> Was this even the right approach? I didn't want to go messing with
> git-commit, frankly, so I am hoping that these new templates might
> just do the trick.
>
> You might ask why I've got such a large list of untracked files -- the
> reason is because I use the same repository to build files in, which
> themselves have no need to be added. And whilst I can catch some of
> these instances by using .gitignore, it's not enough since not all of
> the files have a common extension or anything. And whilst I realise
> the list of untracked file is just a friendly warning to me, I find it
> annoying and would rather it didn't appear at all if possible, since I
> know myself which files need explicitly adding. :)
a) The files don't need a common anything to be ignored with .gitignore. It
is a list of patterns, so you can list the names. Of course not suitable
if the names change or there is really a huge amount of them.
b) There is actually no problem in tracking files that match ignore pattern,
as it is only applied to files that don't appear in index. That gives you
the option to simply ignore '*' (and live with the minor annoyance that
you have to add -f to add command line -- git commit -a and git add -u
will include changes in tracked files all right).
c) Consider changing the build process to put the built files in
a subdirectory, if you have a chance. In my experience it not only helps
keeping track whether everything is versioned that should be, but also
helps navigating the tree (no uninteresting files interfering with shell
completion/cluttering file selection dialogs) and offer easy way to do
a clean build when you suspect the build might have screwed up somewhere
(just delete the directory).
--
Jan 'Bulb' Hudec <bulb@ucw.cz>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2007-08-08 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 12:32 Template commit messages Thomas Adam
2007-08-08 16:24 ` Jan Hudec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070808162411.GA4884@efreet.light.src \
--to=bulb@ucw.cz \
--cc=git@vger.kernel.org \
--cc=thomas.adam22@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).