From: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] Reinstate the old behaviour when GIT_DIR is set and GIT_WORK_TREE is unset
Date: Fri, 10 Aug 2007 13:28:21 +0200 [thread overview]
Message-ID: <20070810112821.GA11026@informatik.uni-freiburg.de> (raw)
In-Reply-To: <7vr6mbu8iv.fsf_-_@assigned-by-dhcp.cox.net>
Hello Junio,
Junio C Hamano wrote:
> From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Date: Sun, 5 Aug 2007 14:12:53 +0100
>
> The old behaviour was to unilaterally default to the cwd is the work tree
> when GIT_DIR was set, but GIT_WORK_TREE wasn't, no matter if we are inside
> the GIT_DIR, or if GIT_DIR is actually something like ../../../.git.
>
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > I think I sent a patch for that, but was negative about it, even if I
> > promised not to question your decision.
>
> Yes you did. Here is a refresher with an affected test
> adjusted.
>
> We already have a few changes that worked around the semantics
> change by either setting GIT_WORK_TREE or cd'ing up, but I
> think they should not need to be reverted.
>
> It makes more sense to keep the old semantics -- people who use
> unusual GIT_DIR setting should know what they are doing, and
> the new GIT_WORK_TREE feature (and core.worktree) would give
> them better control. We just should not break existing users
> that set GIT_DIR and nothing else. Which means I need another
> rewrite on the Release Notes, and probably yet another rc
> cycle.
I don't know if you planed to make
git checkout-index --prefix=/tmp/tra -a
work (again) in a bare repo. Probably not, so it's no surprise that it
still doesn't work.
Best regards
Uwe
--
Uwe Kleine-König
cat /*dev/null; echo 'Hello World!';
cat > /dev/null <<*/
() { } int main() { printf("Hello World!\n");}
/* */
next prev parent reply other threads:[~2007-08-10 11:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-04 22:20 [PATCH] checkout-index needs a working tree Johannes Schindelin
2007-08-04 22:50 ` Junio C Hamano
2007-08-05 1:33 ` Johannes Schindelin
2007-08-09 22:35 ` Uwe Kleine-König
2007-08-10 0:31 ` Johannes Schindelin
2007-08-10 0:55 ` Junio C Hamano
2007-08-10 1:11 ` Johannes Schindelin
2007-08-10 7:57 ` [PATCH] Reinstate the old behaviour when GIT_DIR is set and GIT_WORK_TREE is unset Junio C Hamano
2007-08-10 11:28 ` Uwe Kleine-König [this message]
2007-08-10 19:26 ` Junio C Hamano
2007-08-11 5:17 ` Junio C Hamano
2007-08-11 18:15 ` [PATCH] checkout-index doc: use --work-dir in the export example Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070810112821.GA11026@informatik.uni-freiburg.de \
--to=ukleinek@informatik.uni-freiburg.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).