git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Hausmann <simon@lst.de>
To: "Reece Dunn" <msclrhd@googlemail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] git-p4: Fix sorting changelists when cloning a Perforce repository
Date: Mon, 13 Aug 2007 23:45:17 +0200	[thread overview]
Message-ID: <200708132345.23647.simon@lst.de> (raw)
In-Reply-To: <3f4fd2640708131150r1d9fb02ai1f655a22658cb544@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

On Monday 13 August 2007 20:50:59 Reece Dunn wrote:
> Hi,
>
> When performing a git-p4 clone operation on a Perforce repository,
> where the changelists change in order of magnitude (e.g. 100 to 1000),
> the set of changes to import from is not sorted properly. This is
> because the data in the list is strings not integers. The other place
> where this is done already converts the value to an integer, so it is
> not affected.
>
> This patch fixes this issue.

Acked-by: Simon Hausmann <simon@lst.de>


Thanks,
Simon

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-08-13 21:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13 18:50 [PATCH] git-p4: Fix sorting changelists when cloning a Perforce repository Reece Dunn
2007-08-13 21:45 ` Simon Hausmann [this message]
2007-08-13 23:51   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708132345.23647.simon@lst.de \
    --to=simon@lst.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=msclrhd@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).