git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Shoemaker <c.shoemaker@cox.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Alex Riesen <raa.lkml@gmail.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: merge-recursive: do not rudely die on binary merge
Date: Tue, 14 Aug 2007 19:14:22 -0400	[thread overview]
Message-ID: <20070814231422.GA10662@pe.Belkin> (raw)
In-Reply-To: <7v1we5bvbw.fsf@assigned-by-dhcp.cox.net>

On Tue, Aug 14, 2007 at 03:33:07PM -0700, Junio C Hamano wrote:
> When you try to merge a path that involves binary file-level
> merge, merge-recursive died rudely without cleaning up its own
> mess.  A files added by the merge were left in the working tree,
> but the index was not written out (because it just punted and
> died), so it was cumbersome for the user to retry it by first
> running "git reset --hard".
> 
> This changes merge-recursive to still warn but do the "binary"
> merge for such a path; leave the "our" version in the working
> tree, but still keep the path unmerged so that the user can sort
> it out.

Very nice. Thanks, Junio.  As an additional convenience, it would be
nice to make the "theirs" version easily accessible.  Perhaps, by
leaving an untracked file in the working tree, with the original
filename, suffixed with a hash-prefix.  Or alternatively,
cut-n-pastable instuctions on stdout for replacing the file with the
"theirs" version.

On the other hand, I tend to think that "theirs" would be a better
default than "ours" anyway - still leaving the path unmerged, of
course.

-chris

  reply	other threads:[~2007-08-14 23:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-14 22:33 merge-recursive: do not rudely die on binary merge Junio C Hamano
2007-08-14 23:14 ` Chris Shoemaker [this message]
2007-08-15  0:07   ` Junio C Hamano
2007-08-15 11:19     ` Nikodemus Siivola
2007-08-15 11:50       ` Junio C Hamano
2007-08-20  3:36     ` [PATCH] Document what the stage numbers in the :$n:path syntax mean Steven Grimm
2007-08-20  5:52       ` Jeff King
2007-08-20  6:05         ` Shawn O. Pearce
2007-08-20  6:13           ` Shawn O. Pearce
2007-08-20  7:15             ` Florian Weimer
2007-08-20  8:04               ` Jeff King
2007-08-20  6:30           ` Junio C Hamano
2007-08-20  6:44             ` Jeff King
2007-08-22  0:14             ` Jakub Narebski
2007-08-20  6:37           ` Jeff King
2007-08-20  9:55         ` [PATCH] Document what the stage numbers in the :$n:path syntaxmean Johannes Sixt
2007-08-20  6:20       ` [PATCH] Document what the stage numbers in the :$n:path syntax mean Junio C Hamano
2007-08-20 18:08         ` Jan Hudec
2007-08-20 19:55           ` Junio C Hamano
2007-08-15  0:09   ` merge-recursive: do not rudely die on binary merge Junio C Hamano
2007-08-15  0:18     ` Chris Larson
2007-08-15  1:16     ` Chris Shoemaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070814231422.GA10662@pe.Belkin \
    --to=c.shoemaker@cox.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).