git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
To: Jan Hudec <bulb@ucw.cz>
Cc: "Karl Hasselström" <kha@treskal.com>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	git@vger.kernel.org
Subject: Re: call external editor from git-gui?
Date: Wed, 15 Aug 2007 20:31:49 +0200	[thread overview]
Message-ID: <20070815183149.GD1644@informatik.uni-freiburg.de> (raw)
In-Reply-To: <20070815182228.GA3419@efreet.light.src>

Hello,

Jan Hudec wrote:
> On Tue, Aug 14, 2007 at 09:00:00 +0200, Karl Hasselström wrote:
> > On 2007-08-14 00:55:11 -0400, Shawn O. Pearce wrote:
> > > Spawning the user's preferred editor would be a nice way to get some
> > > of that.
> > 
> > Mmm. I wouldn't call it a _nice_ way: popping up an external program
> > just to get the right text editing behavior. More like the _only_ way,
> > if the user is picky enough.
> 
> It might actually have a rather serious twist. Often the editor for
> git-commit would use the terminal git-commit runs on. But for git-gui you may
> not have any terminal (running git-gui from context menu of some file
> manager) and even if you do, the user does not expect it to be used. So the
> user may -- and quite often will -- want different editors for running from
> git-gui and git-commit.

Alternatively you need to find out/let the user specify if her editor
needs a terminal and then use

	xterm -e myfavoriteeditor

or simply

	myfavoriteeditor

depending on the result.

Best regards
Uwe

-- 
Uwe Kleine-König

$ dc -e "5735816763073014741799356604682P"

  reply	other threads:[~2007-08-15 18:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10 15:30 call external editor from git-gui? Karl Hasselström
2007-08-14  4:55 ` Shawn O. Pearce
2007-08-14  7:00   ` Karl Hasselström
2007-08-15 18:22     ` Jan Hudec
2007-08-15 18:31       ` Uwe Kleine-König [this message]
2007-08-15 18:38       ` David Kastrup
2007-08-16  7:59         ` Mike Ralphson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070815183149.GD1644@informatik.uni-freiburg.de \
    --to=ukleinek@informatik.uni-freiburg.de \
    --cc=bulb@ucw.cz \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).