From: arjen@yaph.org (Arjen Laarhoven)
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] t1301-shared-repo.sh: fix 'stat' portability issue
Date: Fri, 17 Aug 2007 00:02:17 +0200 [thread overview]
Message-ID: <20070816220217.GH25161@regex.yaph.org> (raw)
In-Reply-To: <7v3ayjjnz7.fsf@gitster.siamese.dyndns.org>
The t1301-shared-repo.sh testscript uses /usr/bin/stat to get the file
mode, which isn't portable. Implement the test in shell using 'ls' as
shown by Junio.
Signed-off-by: Arjen Laarhoven <arjen@yaph.org>
---
t/t1301-shared-repo.sh | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
index bb5f302..6bfe19a 100755
--- a/t/t1301-shared-repo.sh
+++ b/t/t1301-shared-repo.sh
@@ -21,7 +21,16 @@ test_expect_success 'update-server-info honors core.sharedRepository' '
git commit -m a1 &&
umask 0277 &&
git update-server-info &&
- test 444 = $(stat -c %a .git/info/refs)
+ actual="$(ls -l .git/info/refs)" &&
+ case "$actual" in
+ -r--r--r--*)
+ : happy
+ ;;
+ *)
+ echo Oops, .git/info/refs is not 0444
+ false
+ ;;
+ esac
'
test_done
--
1.5.3.rc4.67.gf9286
> > - test 444 = $(stat -c %a .git/info/refs)
> > + $(perl -e '\''exit !(((stat ".git/info/refs")[2] & 0777) == 0444)'\'')
> > '
>
> Why is this inside a $()?
Bah.
> I am just wondering if this is more portable and readable...
>
> ... &&
> current="$(ls -l .git/info/refs)" &&
> case "$current" in
> -r--r--r--*)
> : happy
> ;;
> *)
> echo Oops, .git/info/refs is not 0444
> false
> ;;
> esac
next prev parent reply other threads:[~2007-08-16 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 15:21 [PATCH] t1301-shared-repo.sh: fix 'stat' portability issue Arjen Laarhoven
2007-08-16 19:09 ` Junio C Hamano
2007-08-16 22:02 ` Arjen Laarhoven [this message]
2007-08-17 12:48 ` Uwe Kleine-König
2007-08-17 23:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070816220217.GH25161@regex.yaph.org \
--to=arjen@yaph.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).