git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sven Verdoolaege <skimo@kotnet.org>
To: Lars Hjemli <hjemli@gmail.com>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Lars Hjemli <lh@elementstorage.no>
Subject: Re: [PATCH] git-submodule: re-enable 'status' as the default subcommand
Date: Fri, 17 Aug 2007 11:09:47 +0200	[thread overview]
Message-ID: <20070817090947.GG1070MdfPADPa@greensroom.kotnet.org> (raw)
In-Reply-To: <7vmywqh98d.fsf@gitster.siamese.dyndns.org> <11862375532593-git-send-email-hjemli@gmail.com>

On Sat, Aug 04, 2007 at 04:25:53PM +0200, Lars Hjemli wrote:
> This was broken as part of ecda072380.
> 
> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> ---
>  git-submodule.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 2cfeadd..3320998 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -313,7 +313,7 @@ case "$add,$init,$update,$status,$cached" in
>  ,,1,,)
>  	modules_update "$@"
>  	;;
> -,,,1,*)
> +,,,*,*)
>  	modules_list "$@"
>  	;;
>  *)

Sorry about that.  I didn't realize that it was supposed to do that
(it seems I didn't read the manual carefully enough) and I forgot
to mention I changed it.

On Fri, Aug 17, 2007 at 01:10:42AM -0700, Junio C Hamano wrote:
> "Lars Hjemli" <lh@elementstorage.no> writes:
> > I got no response on this patch, was it simply overlooked? I really think
> >
> > $ git submodule
> >
> > should show the available submodules and their status.
> 
> Probably.  I do not think of any other alternative behaviour
> that would make sense.
> 
> Sven?

No objections from me.

skimo

      reply	other threads:[~2007-08-17  9:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-04 14:25 [PATCH] git-submodule: re-enable 'status' as the default subcommand Lars Hjemli
2007-08-17  7:25 ` Lars Hjemli
2007-08-17  8:10   ` Junio C Hamano
2007-08-17  9:09     ` Sven Verdoolaege [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070817090947.GG1070MdfPADPa@greensroom.kotnet.org \
    --to=skimo@kotnet.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hjemli@gmail.com \
    --cc=lh@elementstorage.no \
    --cc=skimo@liacs.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).