From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alex Riesen <raa.lkml@gmail.com>, git@vger.kernel.org
Subject: Re: git-stash segfaults ...
Date: Tue, 21 Aug 2007 03:08:09 -0400 [thread overview]
Message-ID: <20070821070809.GA8545@coredump.intra.peff.net> (raw)
In-Reply-To: <7v6439pecf.fsf@gitster.siamese.dyndns.org>
On Mon, Aug 20, 2007 at 11:54:24PM -0700, Junio C Hamano wrote:
> I think you were told that your patch was a band-aid for the
> symptom, and was not the real fix, in the thread you quoted.
To which I responded that it is still better to report an error than it
is to segfault. In this case, the error message _isn't_ fixing the main
problem, but at least it gives a better starting point for tracking
problems than a segfault. Not to mention that it _does_ provide the
correct error message in a variety of other situations (e.g.,
merge-recursive given bogus arguments).
But really, merge-recursive isn't generally called by users, and so it
shouldn't get bogus input, so perhaps it isn't worth caring about.
-Peff
next prev parent reply other threads:[~2007-08-21 7:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 17:44 git-stash segfaults Pierre Habouzit
2007-08-20 20:02 ` Alex Riesen
2007-08-21 6:05 ` Jeff King
2007-08-21 6:54 ` Junio C Hamano
2007-08-21 7:08 ` Jeff King [this message]
2007-08-20 20:44 ` Junio C Hamano
2007-08-20 20:50 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070821070809.GA8545@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).