git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Hudec <bulb@ucw.cz>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [RFC] git-mergetool: show original branch names when possible
Date: Tue, 21 Aug 2007 16:59:43 +0200	[thread overview]
Message-ID: <20070821145943.GI8542@efreet.light.src> (raw)
In-Reply-To: <20070821061014.GB7323@coredump.intra.peff.net>

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

On Tue, Aug 21, 2007 at 02:10:14 -0400, Jeff King wrote:
> On Mon, Aug 20, 2007 at 08:17:25PM +0200, Jan Hudec wrote:
> 
> > > I think this is a failing of git-merge, though, for not including that
> > > nice human-readable information. We can fix it with something like this:
> > 
> > Maybe you could call git-name-rev on it if it does not come with
> > a human-readable name.
> 
> I considered that, but it has two drawbacks:
> 
>   1. It does not handle pulls which have no tracking branch (the only
>      ref we have is FETCH_HEAD, which is not a useful name :) ).

If there's no useful name, than it's probably hard to do anything at all
about it. Though FETCH_HEAD is not all that useless -- it at least says it is
that that you pull.

>   2. In some circumstances, it can come up with counter-intuitive
>      names. If more than one ref points to a given commit, then you can
>      end up with something like "git-merge foo" telling you all about
>      the merge conflicts with "bar". But perhaps that is too obscure a
>      corner case to worry about.

I meant it as a fallback, for cases where it for some reason can't be
recorded or is not recorded. Recording it is obviously better.

-- 
						 Jan 'Bulb' Hudec <bulb@ucw.cz>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-08-21 14:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20  7:53 [RFC] git-mergetool: show original branch names when possible Jeff King
2007-08-20  8:28 ` Junio C Hamano
2007-08-20  8:52   ` Jeff King
2007-08-20 18:17     ` Jan Hudec
2007-08-21  6:10       ` Jeff King
2007-08-21 14:59         ` Jan Hudec [this message]
2007-08-21 20:55           ` Jeff King
2007-08-21 21:17             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070821145943.GI8542@efreet.light.src \
    --to=bulb@ucw.cz \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).