a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[Randal L. Schwartz]

xmlto -m callouts.xsl man git-rev-list.xml
xmlto: input does not validate (status 3)
/Volumes/UFS/MIRROR/git-GIT/Documentation/git-rev-list.xml:512: element literal: validity error : Element emphasis is not declared in literal list of possible children
/Volumes/UFS/MIRROR/git-GIT/Documentation/git-rev-list.xml:512: element literal: validity error : Element emphasis is not declared in literal list of possible children
/Volumes/UFS/MIRROR/git-GIT/Documentation/git-rev-list.xml:512: element literal: validity error : Element emphasis is not declared in literal list of possible children
Document /Volumes/UFS/MIRROR/git-GIT/Documentation/git-rev-list.xml does not validate
make[1]: *** [git-rev-list.1] Error 3
rm git-checkout.xml
make: *** [doc] Error 2


-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!

Re: a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[Junio C Hamano]

I think we've seen it reported that docbook-xsl 1.72 and/or 1.73
are broken.  Is your debug log from either of these versions?

Re: a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[Randal L. Schwartz]

>>>>> "Junio" == Junio C Hamano <gitster@pobox.com> writes:

Junio> I think we've seen it reported that docbook-xsl 1.72 and/or 1.73
Junio> are broken.  Is your debug log from either of these versions?

1.71

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!

Re: a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[Mike Hommey]

On Tue, Aug 21, 2007 at 02:15:26PM -0700, Junio C Hamano <gitster@pobox.com> wrote:
> I think we've seen it reported that docbook-xsl 1.72 and/or 1.73
> are broken.  Is your debug log from either of these versions?

The problems brought by docbook-xsl 1.72 are from a different nature.
Also note they only make a problem with the output, and don't break the
build.

Mike

Re: a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[Junio C Hamano]

merlyn@stonehenge.com (Randal L. Schwartz) writes:

>>>>>> "Junio" == Junio C Hamano <gitster@pobox.com> writes:
>
> Junio> I think we've seen it reported that docbook-xsl 1.72 and/or 1.73
> Junio> are broken.  Is your debug log from either of these versions?
>
> 1.71

Interesting.  I use 1.71 here too but it does not break.

I wonder what the differences are between our environments
(don't answer that you use OSX and I use Debian and FC -- that
much I already know).

Re: a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[Shawn O. Pearce]

Junio C Hamano <gitster@pobox.com> wrote:
> merlyn@stonehenge.com (Randal L. Schwartz) writes:
> 
> >>>>>> "Junio" == Junio C Hamano <gitster@pobox.com> writes:
> >
> > Junio> I think we've seen it reported that docbook-xsl 1.72 and/or 1.73
> > Junio> are broken.  Is your debug log from either of these versions?
> >
> > 1.71
> 
> Interesting.  I use 1.71 here too but it does not break.
> 
> I wonder what the differences are between our environments
> (don't answer that you use OSX and I use Debian and FC -- that
> much I already know).

It broke at day-job on Cygwin today.  I don't know what version
of docbook-xsl I'm using there.  But its fine on my OSX system.
I had planned on debugging it at home tonight, but I can't reproduce
it here.  Cute.  I will look at it again tomorrow and see if I can
debug the issue.

I'm pretty sure it was my recent edit to git-rev-list.txt; its
one of the only commits that has impacted that manual page since
the last time I had built that manual on Cygwin.  And no, nothing
else (e.g. docbook, asciidoc, xmlto) has changed since the last
successful build.

-- 
Shawn.

Re: a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[David Kastrup]

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Junio C Hamano <gitster@pobox.com> wrote:
>> merlyn@stonehenge.com (Randal L. Schwartz) writes:
>> 
>> >>>>>> "Junio" == Junio C Hamano <gitster@pobox.com> writes:
>> >
>> > Junio> I think we've seen it reported that docbook-xsl 1.72 and/or 1.73
>> > Junio> are broken.  Is your debug log from either of these versions?
>> >
>> > 1.71
>> 
>> Interesting.  I use 1.71 here too but it does not break.
>> 
>> I wonder what the differences are between our environments
>> (don't answer that you use OSX and I use Debian and FC -- that
>> much I already know).
>
> It broke at day-job on Cygwin today.  I don't know what version
> of docbook-xsl I'm using there.  But its fine on my OSX system.
> I had planned on debugging it at home tonight, but I can't reproduce
> it here.  Cute.  I will look at it again tomorrow and see if I can
> debug the issue.
>
> I'm pretty sure it was my recent edit to git-rev-list.txt; its
> one of the only commits that has impacted that manual page since
> the last time I had built that manual on Cygwin.  And no, nothing
> else (e.g. docbook, asciidoc, xmlto) has changed since the last
> successful build.

Maybe a line end character issue?

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[David Kastrup]

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Junio C Hamano <gitster@pobox.com> wrote:
>> merlyn@stonehenge.com (Randal L. Schwartz) writes:
>> 
>> >>>>>> "Junio" == Junio C Hamano <gitster@pobox.com> writes:
>> >
>> > Junio> I think we've seen it reported that docbook-xsl 1.72 and/or 1.73
>> > Junio> are broken.  Is your debug log from either of these versions?
>> >
>> > 1.71
>> 
>> Interesting.  I use 1.71 here too but it does not break.
>> 
>> I wonder what the differences are between our environments
>> (don't answer that you use OSX and I use Debian and FC -- that
>> much I already know).
>
> It broke at day-job on Cygwin today.  I don't know what version
> of docbook-xsl I'm using there.  But its fine on my OSX system.
> I had planned on debugging it at home tonight, but I can't reproduce
> it here.  Cute.  I will look at it again tomorrow and see if I can
> debug the issue.
>
> I'm pretty sure it was my recent edit to git-rev-list.txt; its
> one of the only commits that has impacted that manual page since
> the last time I had built that manual on Cygwin.  And no, nothing
> else (e.g. docbook, asciidoc, xmlto) has changed since the last
> successful build.

Line ending problem?

[P.S.: due to a stuck mail server at home, some message similar to
this one will appear in the evening]

-- 
David Kastrup

Re: a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[Junio C Hamano]

Is this only with "make git-rev-list.1"?

Can your setup format d56651c0^ aka 14cd5607 correctly?  IOW, does

	$ git checkout 14cd5607 && cd Documentation && make git-rev-list.1

work well while

	$ git checkout a475e809 && cd Documentation && make git-rev-list.1

doesn't?

Re: a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[Randal L. Schwartz]

>>>>> "Junio" == Junio C Hamano <gitster@pobox.com> writes:

Junio> 	$ git checkout 14cd5607 && cd Documentation && make git-rev-list.1

This works fine.

Junio> 	$ git checkout a475e809 && cd Documentation && make git-rev-list.1

And this fails.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!

Re: a475e8095aeb898c1ca60673b82df97d2300cc95 broken for docs

[Junio C Hamano]

Thanks.  One difference we overlooked was the differences in
versions of AsciiDoc; Quy sees problem with 8 while I do not
with 7 (both my private machine and k.org machine -- the latter
of which is where preformatted documentation pages in html and
man branches come from).  I think Shawn was correct to pinpoint
that exact change as the culprit and Quy Tonthat is on the right
track, with this patch...



diff --git a/Documentation/git-rev-list.txt b/Documentation/git-rev-list.txt
index cbbc234..a0c611e 100644
--- a/Documentation/git-rev-list.txt
+++ b/Documentation/git-rev-list.txt
@@ -298,8 +298,8 @@ used in the output.  When the starting commit is specified as
 'commit@{now}', output also uses 'commit@\{timestamp}' notation
 instead.  Under '\--pretty=oneline', the commit message is
 prefixed with this information on the same line.
-+
-Cannot be combined with --reverse.
+
+Cannot be combined with '\--reverse'.
 
 --merge::
 
@@ -375,7 +375,7 @@ By default, the commits are shown in reverse chronological order.
 --reverse::
 
 	Output the commits in reverse order.
-	Cannot be combined with --walk-reflogs.
+	Cannot be combined with '\--walk-reflogs'.
 
 Object Traversal
 ~~~~~~~~~~~~~~~~