From: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
To: David Jack Olrik <david@olrik.dk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison.
Date: Wed, 22 Aug 2007 15:23:59 +0200 [thread overview]
Message-ID: <20070822132359.GA13750@informatik.uni-freiburg.de> (raw)
In-Reply-To: <9E40DAA3-69E5-417C-8041-E1980E42DB60@olrik.dk>
David Jack Olrik wrote:
>
> On 22/08/2007, at 14.21, Uwe Kleine-König wrote:
>
> >David Jack Olrik wrote:
> >>- if test "`expr index $httpd_only /`" -eq '1' || \
> >>+ if test "`echo $httpd_only | cut -c 1`" = '/' || \
> >> which $httpd_only >/dev/null
> >
> >I wonder why not use:
> >
> > if expr "z$httpd_only" : "z/" >/dev/null
>
> You'd then need to check against 2 instead of 1, which I find less
> obvious as we are testing for a '/' at the begining of the string.
If I understood the problem right you only need to test for the exit
code, that is the program test is not required at all.
Best regards
Uwe
--
Uwe Kleine-König
http://www.google.com/search?q=5%2B7
next prev parent reply other threads:[~2007-08-22 13:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 12:02 [PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison David Jack Olrik
2007-08-22 12:21 ` Uwe Kleine-König
2007-08-22 12:30 ` David Jack Olrik
2007-08-22 13:23 ` Uwe Kleine-König [this message]
2007-08-22 20:18 ` [PATCH] Fixed non portable use of expr and removed " David Jack Olrik
2007-08-22 21:56 ` Junio C Hamano
2007-08-23 9:06 ` Uwe Kleine-König
2007-08-23 9:25 ` Junio C Hamano
2007-08-23 10:02 ` Uwe Kleine-König
2007-08-23 8:58 ` Uwe Kleine-König
2007-08-22 21:00 ` [PATCH] Fixed non portable use of expr, and " martin f krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070822132359.GA13750@informatik.uni-freiburg.de \
--to=ukleinek@informatik.uni-freiburg.de \
--cc=david@olrik.dk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).