From: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: David Jack Olrik <david@olrik.dk>, git@vger.kernel.org
Subject: Re: [PATCH] Fixed non portable use of expr and removed incorrect use of test -eq for string comparison
Date: Thu, 23 Aug 2007 11:06:00 +0200 [thread overview]
Message-ID: <20070823090600.GB6573@informatik.uni-freiburg.de> (raw)
In-Reply-To: <7vejhvi67x.fsf@gitster.siamese.dyndns.org>
Hello Junio,
Junio C Hamano wrote:
> By the way, I do not know if the use of "which" there is
> portable. Have Solaris folks tried this program ever?
I don't count myself to "Solaris folks", even though I still use it to
read and write my email. But anyhow I know some of the pitfalls...
login@~ > /bin/bash --version
GNU bash, version 3.00.16(1)-release (sparc-sun-solaris2.10)
Copyright (C) 2004 Free Software Foundation, Inc.
login@~ > /bin/bash
zeisberg@login ~$ which httpd && echo successful
no httpd in /home/zeisberg/bin /home/zeisberg/usr/bin /opt/bin
/usr/local/graphics/bin /usr/local/gnu/bin /usr/local/bin
/usr/local/X11R6/bin /usr/xpg4/bin /usr/bin /usr/ccs/bin /usr/sbin
/usr/ucb /usr/openwin/bin
successful
That is, with httpd_only=httpd I get:
$ if expr "z$httpd_only" : "z/" >/dev/null || \
which $httpd_only >/dev/null
then
$httpd_only arg1 arg2
fi
bash: httpd: command not found
Best regards
Uwe
--
Uwe Kleine-König
If a lawyer and an IRS agent were both drowning, and you could only save
one of them, would you go to lunch or read the paper?
next prev parent reply other threads:[~2007-08-23 9:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 12:02 [PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison David Jack Olrik
2007-08-22 12:21 ` Uwe Kleine-König
2007-08-22 12:30 ` David Jack Olrik
2007-08-22 13:23 ` Uwe Kleine-König
2007-08-22 20:18 ` [PATCH] Fixed non portable use of expr and removed " David Jack Olrik
2007-08-22 21:56 ` Junio C Hamano
2007-08-23 9:06 ` Uwe Kleine-König [this message]
2007-08-23 9:25 ` Junio C Hamano
2007-08-23 10:02 ` Uwe Kleine-König
2007-08-23 8:58 ` Uwe Kleine-König
2007-08-22 21:00 ` [PATCH] Fixed non portable use of expr, and " martin f krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823090600.GB6573@informatik.uni-freiburg.de \
--to=ukleinek@informatik.uni-freiburg.de \
--cc=david@olrik.dk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).