git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison.
@ 2007-08-22 12:02 David Jack Olrik
  2007-08-22 12:21 ` Uwe Kleine-König
  2007-08-22 21:00 ` [PATCH] Fixed non portable use of expr, and " martin f krafft
  0 siblings, 2 replies; 11+ messages in thread
From: David Jack Olrik @ 2007-08-22 12:02 UTC (permalink / raw)
  To: git; +Cc: David Jack Olrik


Signed-off-by: David Jack Olrik <david@olrik.dk>
---
 git-instaweb.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-instaweb.sh b/git-instaweb.sh
index b79c6b6..da8eb3f 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -30,7 +30,7 @@ test -z "$port" && port=1234
 
 start_httpd () {
 	httpd_only="`echo $httpd | cut -f1 -d' '`"
-	if test "`expr index $httpd_only /`" -eq '1' || \
+	if test "`echo $httpd_only | cut -c 1`" = '/' || \
 				which $httpd_only >/dev/null
 	then
 		$httpd $fqgitdir/gitweb/httpd.conf
-- 
1.5.3.rc6

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2007-08-23 10:02 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-22 12:02 [PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison David Jack Olrik
2007-08-22 12:21 ` Uwe Kleine-König
2007-08-22 12:30   ` David Jack Olrik
2007-08-22 13:23     ` Uwe Kleine-König
2007-08-22 20:18       ` [PATCH] Fixed non portable use of expr and removed " David Jack Olrik
2007-08-22 21:56         ` Junio C Hamano
2007-08-23  9:06           ` Uwe Kleine-König
2007-08-23  9:25             ` Junio C Hamano
2007-08-23 10:02               ` Uwe Kleine-König
2007-08-23  8:58         ` Uwe Kleine-König
2007-08-22 21:00 ` [PATCH] Fixed non portable use of expr, and " martin f krafft

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).