From: bdowning@lavos.net (Brian Downing)
To: "Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [BUG] git-gui: "Stage Hunk For Commit" doesn't work at all anymore
Date: Thu, 23 Aug 2007 15:30:24 -0500 [thread overview]
Message-ID: <20070823203024.GF21692@lavos.net> (raw)
This commit:
commit a13ee29b975d3a9a012983309e842d942b2bbd44
Author: Shawn O. Pearce <spearce@spearce.org>
Date: Thu Aug 2 22:55:22 2007 -0400
git-gui: Avoid Tcl error in popup menu on diff viewer
If there is no path currently shown in the diff viewer then we
were getting Tcl errors anytime the user right-clicked on the
diff viewer to bring up its popup menu. The bug here is caused
by trying to get the file_state for the empty string; this path
is never seen so we never have file_state for it. In such cases
we now disable the Stage Hunk For Commit option.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
seems to have broken the "Stage Hunk For Commit" option entirely for me
-- it is now disabled whether or not there is a patch in the viewer.
-bcd
next reply other threads:[~2007-08-23 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 20:30 Brian Downing [this message]
2007-08-23 20:38 ` [BUG] git-gui: "Stage Hunk For Commit" doesn't work at all anymore Brian Downing
2007-08-24 3:08 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823203024.GF21692@lavos.net \
--to=bdowning@lavos.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).