From: "Karl Hasselström" <kha@treskal.com>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: git@vger.kernel.org
Subject: [StGIT PATCH 0/4] Clean up subprocess calling
Date: Sun, 26 Aug 2007 22:33:21 +0200 [thread overview]
Message-ID: <20070826202724.16265.85821.stgit@yoghurt> (raw)
We had nearly ten separate functions implementing about five different
ways of calling a subprocess. This series cleans it up. The aggregate
diffstat looks scary, but that's mostly because these functions were
called in a bajillion different places.
If you choose to pull from my repository (which I highly recommend!),
note that this series is built on top of the misc fixes, so you get
those as well.
The following changes since commit 216a1524c4acbd9952ffaeec054e30cf14dde5fc:
Karl Hasselström (1):
Compile regexp just once
are available in the git repository at:
git://repo.or.cz/stgit/kha.git run
Karl Hasselström (4):
Refactor output handling to break circular dependency
Refactor subprocess creation
Assert that the argument to Run is a sequence of strings
Add optional logging of subprocess execution
stgit/basedir.py | 13 +-
stgit/commands/applied.py | 1 +
stgit/commands/assimilate.py | 1 +
stgit/commands/branch.py | 1 +
stgit/commands/clean.py | 1 +
stgit/commands/commit.py | 1 +
stgit/commands/common.py | 1 +
stgit/commands/delete.py | 1 +
stgit/commands/diff.py | 1 +
stgit/commands/export.py | 10 +-
stgit/commands/files.py | 1 +
stgit/commands/fold.py | 1 +
stgit/commands/hide.py | 1 +
stgit/commands/id.py | 1 +
stgit/commands/imprt.py | 1 +
stgit/commands/log.py | 1 +
stgit/commands/mail.py | 1 +
stgit/commands/patches.py | 1 +
stgit/commands/pick.py | 1 +
stgit/commands/pull.py | 1 +
stgit/commands/push.py | 1 +
stgit/commands/refresh.py | 1 +
stgit/commands/rename.py | 1 +
stgit/commands/series.py | 1 +
stgit/commands/sync.py | 1 +
stgit/commands/top.py | 1 +
stgit/commands/unapplied.py | 1 +
stgit/commands/uncommit.py | 1 +
stgit/commands/unhide.py | 1 +
stgit/config.py | 56 ++-----
stgit/git.py | 331 +++++++++++++++++-------------------------
stgit/gitmergeonefile.py | 21 +--
stgit/main.py | 2 +-
stgit/out.py | 100 +++++++++++++
stgit/run.py | 141 ++++++++++++++++++
stgit/stack.py | 1 +
stgit/utils.py | 81 +----------
37 files changed, 436 insertions(+), 347 deletions(-)
create mode 100644 stgit/out.py
create mode 100644 stgit/run.py
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle
next reply other threads:[~2007-08-26 20:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-26 20:33 Karl Hasselström [this message]
2007-08-26 20:33 ` [StGIT PATCH 1/4] Refactor output handling to break circular dependency Karl Hasselström
2007-08-26 20:33 ` [StGIT PATCH 2/4] Refactor subprocess creation Karl Hasselström
2007-08-26 20:33 ` [StGIT PATCH 3/4] Assert that the argument to Run is a sequence of strings Karl Hasselström
2007-08-26 20:33 ` [StGIT PATCH 4/4] Add optional logging of subprocess execution Karl Hasselström
2007-08-29 10:50 ` Catalin Marinas
2007-08-29 11:11 ` Karl Hasselström
2007-08-29 17:16 ` Karl Hasselström
2007-09-03 8:34 ` Catalin Marinas
2007-09-03 8:36 ` Catalin Marinas
2007-09-03 9:04 ` Karl Hasselström
2007-09-03 21:48 ` [StGit PATCH 0/2] Break Python 2.3 compatibility Karl Hasselström
2007-09-03 21:48 ` [StGit PATCH 1/2] Use subprocess.Popen to call git executables Karl Hasselström
2007-09-03 21:48 ` [StGit PATCH 2/2] Use the builtin set() instead of sets.Set() Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070826202724.16265.85821.stgit@yoghurt \
--to=kha@treskal.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).