From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] gitweb: Fix file name quoting in simplified out patch detection for --cc output
Date: Sun, 2 Sep 2007 22:22:13 +0200 [thread overview]
Message-ID: <200709022222.13865.jnareb@gmail.com> (raw)
For the --cc (compressed combined) diff output there can be patches
which are simple and got simplified out, so there is no patch
corresponding to raw output line.
Fix detection of of such simplified out patches: file name in git diff
header for --cc diff can be quoted; unquote it.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This patch depends _textually_ on the just send
"gitweb: Fix and simplify "split patch" detection"
patch, although it is _conceptually_ independent.
The commit message could be better...
gitweb/gitweb.perl | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 8c1e02c..5d424e5 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3140,8 +3140,8 @@ sub git_patchset_body {
# compact combined diff output can have some patches skipped
# find which patch (using pathname of result) we are at now
my $to_name;
- if ($patch_line =~ m!^diff --cc "?(.*)"?$!) {
- $to_name = $1;
+ if ($patch_line =~ m!^diff --cc ("?.*"?)$!) {
+ $to_name = unquote($1);
}
do {
--
1.5.2.5
next reply other threads:[~2007-09-02 23:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-02 20:22 Jakub Narebski [this message]
2007-09-03 0:22 ` [PATCH] gitweb: Fix file name quoting in simplified out patch detection for --cc output Junio C Hamano
2007-09-03 9:52 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709022222.13865.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).