* [PATCH 5/5] Use 'unsigned:1' when we mean boolean options
@ 2007-09-18 8:55 Shawn O. Pearce
0 siblings, 0 replies; only message in thread
From: Shawn O. Pearce @ 2007-09-18 8:55 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
These options are all strictly boolean (true/false). Its easier to
document this implicitly by making their storage type a single bit.
There is no compelling memory space reduction reason for this change,
it just makes the structure definition slightly more readable.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
fetch-pack.h | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fetch-pack.h b/fetch-pack.h
index cdcd84f..ad13076 100644
--- a/fetch-pack.h
+++ b/fetch-pack.h
@@ -4,14 +4,14 @@
struct fetch_pack_args
{
const char *uploadpack;
- int quiet;
- int keep_pack;
int unpacklimit;
- int use_thin_pack;
- int fetch_all;
- int verbose;
int depth;
- int no_progress;
+ unsigned quiet:1,
+ keep_pack:1,
+ use_thin_pack:1,
+ fetch_all:1,
+ verbose:1,
+ no_progress:1;
};
void setup_fetch_pack(struct fetch_pack_args *args);
--
1.5.3.1.1000.g7319b
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-09-18 8:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-18 8:55 [PATCH 5/5] Use 'unsigned:1' when we mean boolean options Shawn O. Pearce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).