From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Habouzit Subject: Re: [PATCH 4/5] Full rework of quote_c_style and write_name_quoted. Date: Wed, 19 Sep 2007 03:14:33 +0200 Message-ID: <20070919011433.GE4535@artemis.corp> References: <20070918223947.GB4535@artemis.corp> <20070918224122.2B55D344AB3@madism.org> <20070919000757.GC4535@artemis.corp> <7vabrjtqw7.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="PGNNI9BzQDUtgA2J"; protocol="application/pgp-signature"; micalg=SHA1 Cc: git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Wed Sep 19 03:14:46 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IXo9L-0000aB-0l for gcvg-git-2@gmane.org; Wed, 19 Sep 2007 03:14:43 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750943AbXISBOg (ORCPT ); Tue, 18 Sep 2007 21:14:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750814AbXISBOg (ORCPT ); Tue, 18 Sep 2007 21:14:36 -0400 Received: from pan.madism.org ([88.191.52.104]:56712 "EHLO hermes.madism.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbXISBOf (ORCPT ); Tue, 18 Sep 2007 21:14:35 -0400 Received: from madism.org (olympe.madism.org [82.243.245.108]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "artemis.madism.org", Issuer "madism.org" (not verified)) by hermes.madism.org (Postfix) with ESMTP id C398D20323; Wed, 19 Sep 2007 03:14:34 +0200 (CEST) Received: by madism.org (Postfix, from userid 1000) id E4420344AC1; Wed, 19 Sep 2007 03:14:33 +0200 (CEST) Mail-Followup-To: Pierre Habouzit , Junio C Hamano , git@vger.kernel.org Content-Disposition: inline In-Reply-To: <7vabrjtqw7.fsf@gitster.siamese.dyndns.org> X-Face: $(^e[V4D-[`f2EmMGz@fgWK!e.B~2g.{08lKPU(nc1J~z\4B>*JEVq:E]7G-\6$Ycr4<;Z!|VY6Grt]+RsS$IMV)f>2)M="tY:ZPcU;&%it2D81X^kNya0=L]"vZmLP+UmKhgq+u*\.dJ8G!N&=EvlD User-Agent: Madmutt/devel (Linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: --PGNNI9BzQDUtgA2J Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 19, 2007 at 12:55:52AM +0000, Junio C Hamano wrote: > Pierre Habouzit writes: >=20 > > On Tue, Sep 18, 2007 at 10:00:51PM +0000, Pierre Habouzit wrote: > >> + cp =3D strchr(qname.buf + qname.len + 3 - max, '/'); > >> + if (cp) > >> + cp =3D qname.buf + qname.len + 3 - max; > > > > OMG, this is supposed to be if (!cp) of course... > > > > I wonder how this passed the testsuite. >=20 > You would need a new test, I guess, before a huge rewrite. OTOH this is in the code that generates the diffstats, it's not _that_ surprising that we don't have extensive tests about that, as it's not critical in git afaict ;) --=20 =C2=B7O=C2=B7 Pierre Habouzit =C2=B7=C2=B7O madcoder@debia= n.org OOO http://www.madism.org --PGNNI9BzQDUtgA2J Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBG8Hf5vGr7W6HudhwRAiAuAJ9KTh9+DH5hEh2/wn0MlcKqk1CZDQCfWcxx fInRyCUZ9/VBjjK8Tm3noTQ= =1jFd -----END PGP SIGNATURE----- --PGNNI9BzQDUtgA2J--