From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: Re: [PATCH] Add a --dateformat= option to git-for-each-ref
Date: Fri, 28 Sep 2007 15:15:58 +0100 [thread overview]
Message-ID: <200709281516.05438.andyparkins@gmail.com> (raw)
In-Reply-To: <20070926125811.GC13739@coredump.intra.peff.net>
On Wednesday 2007 September 26, Jeff King wrote:
> would be more flexible. Although perhaps that is a bit too unlikely to
> be concerned with implementing, giving options to substitutions seems
> like a sane way to implement these sorts of things (e.g.,
> "%(objectsize:human)", "%(parent:1)", etc).
I'd thought about doing it like that, but imagined that there would objections
that it was overcomplicating git-for-each-ref. As you think that's
acceptable, I'll do it.
> Surely this same code exists elsewhere, and could be easily factored out
> into a parse_date_type function.
It was. It was also in revisions.c.
A patch series that implements both your requested changes to follow.
Andy
--
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
next prev parent reply other threads:[~2007-09-28 14:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 9:09 [PATCH] Add a --dateformat= option to git-for-each-ref Andy Parkins
2007-09-26 12:58 ` Jeff King
2007-09-28 14:15 ` Andy Parkins [this message]
2007-09-28 14:17 ` [PATCH 1/4] Add parse_date_format() convenience function for converting a format string to an enum date_mode Andy Parkins
2007-09-28 14:17 ` [PATCH 2/4] Use parse_date_format() in revisions.c to parse the --date parameter Andy Parkins
2007-09-28 15:22 ` Johannes Schindelin
2007-09-28 18:00 ` Andy Parkins
2007-09-28 18:11 ` Junio C Hamano
2007-09-29 7:39 ` [PATCH 1/3] Use parse_date_format() convenience function for converting a format string to an enum date_mode in revisions.c Andy Parkins
2007-09-29 7:39 ` [PATCH 2/3] Make for-each-ref allow atom names like "<name>:<something>" Andy Parkins
2007-09-29 7:39 ` [PATCH 3/3] Make for-each-ref's grab_date() support per-atom formatting Andy Parkins
2007-09-28 14:17 ` [PATCH 3/4] Make for-each-ref allow atom names like "<name>:<something>" Andy Parkins
2007-09-28 14:17 ` [PATCH 4/4] Make for-each-ref's grab_date() support per-atom formatting Andy Parkins
2007-09-29 8:17 ` Junio C Hamano
2007-09-28 18:47 ` [PATCH] Add a --dateformat= option to git-for-each-ref Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709281516.05438.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).